#115 alwaysontop button toolbar patch

open
nobody
None
5
2016-08-30
2006-09-07
No

here's the patch against the revision 4586.
it creates a button that toggle the window between the
layer top and normal.

Discussion

  • matteo galiazzo

    matteo galiazzo - 2006-09-07

    patch against the revision 4586

     
  • Simon Bowden

    Simon Bowden - 2007-01-06

    Logged In: YES
    user_id=603593
    Originator: NO

    Hi,

    I've looked over your patch, and have a few notes:

    * Please supply a unified diff (diff -u) and check that it isn't reversed (yours seems to be).
    * Watch your indentation
    * To me, names like "aotPixmap" and "m_aotted_pm" just don't click. Maybe call them something like toggleLayerUp and toggleLayerDown (toggleLayerUpPixmap, m_toggle_layer_up_pm). Yes, it's longer, but then I can read it without thinking so hard.

    If you can fix these, I think we could commit it. In an ideal world, I'd be tempted to make it so that left click goes Top and right click goes Bottom (or some such).

    Cheers,

    - Simon

     
  • matteo galiazzo

    matteo galiazzo - 2007-01-06

    Logged In: YES
    user_id=697338
    Originator: YES

    so i provide a unified patch against the 4646 version
    i've tried to fix all the points in your notes

    i coudn't use the existing methods FluxboxWindow::raiseLayer() and lowerLayer() because they navigate trough all the five layer states (ABOVE DOCK, ecc.), and i have to add my toUpperLayer() and toLowerLayer() that moves only between TOP,NORMAL and BOTTOM.

    cheers

    matteo

    File Added: layersButtonedPatch.patch

     
  • Thomas Luebking

    Thomas Luebking - 2016-08-30

    I suspect this to be some approach on the toggle raise/lower (within! a layer) request which will require some idea about the window stack (to checl for occlusions) for a proper implementation.
    In that case, this patch is wrong (because it doesn't guarantees neither condition, there can be windows up in the atop layer and below in the normal layer)

     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:

JavaScript is required for this form.





No, thanks