#1175 All Heads slit and toolbar options appear to have no effect

[Graham]

Hi,

I'm using the latest git revision (fluxbox -info reproduced below) with a two-head system, but am unable to get either the slit or the toolbar to appear on both simultaneously with their respective "All Heads" options. Setting to "head 1" or "head 2" behaves as expected.

My usual xrandr setup is:
xrandr --output eDP-1 --auto --output DP-2-3 --auto --above eDP-1

Thanks,
-Graham

$ xrandr --query
Screen 0: minimum 320 x 200, current 2560 x 2520, maximum 16384 x 16384
eDP-1 connected primary 1920x1080+0+1440 (normal left inverted right x axis y axis) 309mm x 173mm
   1920x1080     60.00*+  59.97    59.96    59.93    48.00
...
   DP-1 disconnected (normal left inverted right x axis y axis)
HDMI-1 disconnected (normal left inverted right x axis y axis)
DP-2 disconnected (normal left inverted right x axis y axis)
HDMI-2 disconnected (normal left inverted right x axis y axis)
DP-2-1 disconnected (normal left inverted right x axis y axis)
DP-2-2 disconnected (normal left inverted right x axis y axis)
DP-2-3 connected 2560x1440+0+0 (normal left inverted right x axis y axis) 597mm x 336mm
   2560x1440     59.95*+
...

$ fluxbox -info
Fluxbox 1.3.7 : (c) 2001-2015 Fluxbox Team 

GIT Revision: 53fa0d6aaca3eb8a1fe8011e0e3d53cb85e1a772
Compiled: Jan 16 2020 10:46:55
Compiler: GCC
Compiler version: 9.2.0

Defaults: 
       menu: /usr/share/fluxbox/menu
 windowmenu: /usr/share/fluxbox/windowmenu
      style: /usr/share/fluxbox/styles/bloe
       keys: /usr/share/fluxbox/keys
       init: /usr/share/fluxbox/init
         nls: /usr/share/fluxbox/nls

Compiled options (- => disabled): 
BIDI
-DEBUG
EWMH
IMLIB2
NLS
REMEMBER
RENDER
SHAPE
SLIT
SYSTEMTRAY
TOOLBAR
RANDR
XFT
XINERAMA
XMB
XP

[Graham]

I recompiled fluxbox with DEBUG enabled and ran it under valgrind. The valgrind output is attached. There are potentially several bugs here.

Simply starting fluxbox provokes the following:

==35274== Conditional jump or move depends on uninitialised value(s)
==35274==    at 0x1A360B: FluxboxWindow::leaveNotifyEvent(XCrossingEvent&) (Window.cc:2867)
==35274==    by 0x208867: FbTk::EventManager::dispatch(unsigned long, _XEvent&, bool) (EventManager.cc:191)
==35274==    by 0x1C3576: Fluxbox::handleEvent(_XEvent*) (fluxbox.cc:618)
==35274==    by 0x1C3E97: Fluxbox::eventLoop() (fluxbox.cc:541)
==35274==    by 0x140083: main (main.cc:210)
==35274==  Uninitialised value was created by a heap allocation
==35274==    at 0x4838DEF: operator new(unsigned long) (vg_replace_malloc.c:344)
==35274==    by 0x18D09A: BScreen::createWindow(unsigned long) (Screen.cc:1160)
==35274==    by 0x18D6AC: BScreen::initWindows() (Screen.cc:545)
==35274==    by 0x1C7F65: Fluxbox::initScreen(BScreen*) (fluxbox.cc:493)
==35274==    by 0x1CABB7: operator() (stl_function.h:1284)
==35274==    by 0x1CABB7: operator() (binders.h:129)
==35274==    by 0x1CABB7: forAll<std::__cxx11::list<BScreen*>, std::binder1st<std::mem_fun1_t<void, Fluxbox, BScreen*> > > (STLUtil.hh:78)
==35274==    by 0x1CABB7: Fluxbox::Fluxbox(int, char**, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, bool) (fluxbox.cc:448)
==35274==    by 0x13FF95: main (main.cc:208)
==35274==

The remaining memory errors were obtained by clicking the "Toolbar on Head" menu configuration options between "Head 1", "Head 2" and "All Heads". (in no particular order, but I probably clicked each a couple of times )