Code review: TimeoutHandler, added FIXME's

Developers
2013-11-17
2013-11-17
  • Guus Bonnema

    Guus Bonnema - 2013-11-17

    Hi Paul,

    Could you have a look at TimeoutHandler? I have added some remarks.

    TimeoutHandler is outreaching its responsibility. If you agree, I will alter it, so it focusses on its own state and services only.

    Let me know.

    Regards, Guus.

     
  • Guus Bonnema

    Guus Bonnema - 2013-11-17

    I have already changed the code in my workcopy. If you don't agree I can revert. I moved the component related stuff to component and made component call network for removing from the timeouts.

     
  • J. Paul Morrison

    Fixme comments seem very reasonable! I don't see any objections!

     
  • Guus Bonnema

    Guus Bonnema - 2013-11-17

    Thanks, will do.

     

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks