Re: [flint-devel] fmpz_poly_evaluate bug in 1.2.2

[Michael A. <mab...@go...>]

On Tue, Mar 31, 2009 at 2:10 PM, William Hart <ha...@ya...> wrote:
>
> I've just issued FLINT 1.2.3 which addresses this issue. Thanks Burcin.
>
> Amazingly I had made the same mistake in three separate implementations of the same function using different algorithms. They weren't even cut and pastes of each other, but this explains why the doctest wasn't failing. Roughly speaking, the reference implementation was broken!!
>
> Bill.

Hi Bill,

I told you in person, but for the record:

(a) FLINT 1.2.3 cannot compile its test suite on Solaris 10 due to

gcc -std=c99 -I/home/mabshoff/build-3.3/sage-3.3-fulvia/local/include/
-I/home/mabshoff/build-3.3/sage-3.3-fulvia/local/include  -fPIC
-funroll-loops   -O3 -c mpn_extras-test.c -o mpn_extras-test.o
In file included from /usr/include/sys/time.h:99,
                 from profiler.h:30,
                 from test-support.h:36,
                 from mpn_extras-test.c:35:
/usr/include/sys/types.h:536: error: duplicate ‘unsigned’
make: *** [mpn_extras-test.o] Error 1
Error building the test suite for FLINT

The "fix" in this case is to undef ulong in profile.h right before
including time.h and its two friends. I am still waiting on the test
to finish, but so far no failures until Testing
zmod_poly_factor_square_free(). :)

(b) __thread is unsupported on OSX. Removing them (since Sage does not
use a threaded FLINT) does make the library compile and also makes the
test suite pass (I had to swap out CC for CPP for all the test suite
files, but that might be a Sage specific problem). Oddly enough the
wall vs. CPU time seems to often disagree on that OSX box. For example
here a small snippet from the test log where CPU time >> WALL time,
CPU time == Wall time and CPU TIME << WALL time.

Testing zmod_poly_mul_precache()... Cpu = 5666 ms  Wall = 9981 ms ... ok
Testing zmod_poly_mul_trunc_n_precache()... Cpu = 6070 ms  Wall =
10446 ms ... ok
Testing zmod_poly_scalar_mul()... Cpu = 284 ms  Wall = 310 ms ... ok
Testing zmod_poly_make_monic()... Cpu = 4868 ms  Wall = 577 ms ... ok

With the various fixes mentioned above FLINT 1.2.3 passes its test
suite on OSX 10.5/Intel in 32 bit mode.

Cheers,

Michael