Re: [Flightgear-devel] Make Canvas windows reusable by not destroying them on closing

[James T. <ja...@fl...>]

> On 13 Oct 2022, at 15:55, TheFGFSEagle <the...@gm...> wrote:
> 
> Thanks ! :) And be sure to review the other patch about the checkbox too - I attached it to this email for convenience ! ;)

I’ve merged both patches now. The checkbox one is fine.

For this window behaviour one, I’ve applied it since it’s an opt-in change, but I suspect we may end reviewing this API a little, so I’d suggest not building lots of dialogs across different aircraft, which depend on this behaviour, until we get a bit more experience with it. 

So use it, gain some understanding, but maybe we discover in 6 months that it’s a bad idea and have to revert it. (That’s the worst case, but it is kind of a radical change in the lifetime / memory usage of the Canvas, so I just want to mention the worst possibility) I’m 90% sure we can keep this API, so long as we improve the C++ behaviour to release the texture / FBO memory of hidden canvases, which is a reasonable thing to do anyway, it just needs someone to have the time to implement that, and right now, I certainly don’t.

Kind regards,
James