Menu
▾
▴
#98 GPWS mk-viii not working
Originally created by: aeitsch...@yahoo.de
What steps will reproduce the problem?
1. take 737-300 and other aircrafts equipped with FGFS default mk-viii
2. land it manual or with ILS on an airport
What is the expected output? What do you see instead?
Expected the complete callouts begiing with "1000", then "500", "Minimums"
and counting dwon the radar-alt until ground
Instead I can only hear "minimums". More callouts can be hear in Replay
modus
What version of the product are you using? On what operating system?
FGFS 2.0.0, latest 737-300, win32
Please provide any additional information below.
Wrong use?
View and moderate all "codetickets Discussion" comments posted by this user
Mark all as spam, and block user from posting to "Tickets"
Originally posted by: zakalawe@mac.com
I've spent some time trying to make the Mk-VIII work as expected, and not had complete success. For many
aircraft, the problem is installation - the Mk-VIII requires various properties to be defined, notably the decision-
height (DH) and some physical properties such as landing gear height, in order to function correctly.
Status: Accepted
View and moderate all "codetickets Discussion" comments posted by this user
Mark all as spam, and block user from posting to "Tickets"
Originally posted by: zakalawe@mac.com
(No comment was entered for this change.)
Cc: zakalawe
View and moderate all "codetickets Discussion" comments posted by this user
Mark all as spam, and block user from posting to "Tickets"
Originally posted by: bre... (code.google.com)@gmail.com
I have a similar (or same problem). I hear a single call-out during a flight only. The problem can also be reproduced when starting the self-test.
Setting the property "/instruments/mk-viii/inputs/discretes/self-test" to "true" only triggers a single call-out - not all of them as expected.
The attached patch (well, a hack only...) fixes the issue. SGSoundSample's "is_playing" method does not return "false", once the sample has finished playing. So the mk-viii module gets stuck after playing the first sample. I guess Simgear/SGSoundSample is broken. The attached patch adds a 2 second timeout to the MK_VIII::VoicePlayer::Voice::SampleElement::is_playing method. That makes the self-test (and all the call-outs during a flight work).
I guess a better solution is to fix the behaviour of Simgear/SGSoundSample though? I haven't messed with simgear yet.
Thoughts anyone?
View and moderate all "codetickets Discussion" comments posted by this user
Mark all as spam, and block user from posting to "Tickets"
Originally posted by: zakalawe@mac.com
Ah, great work diagnosing this! I'll talk to Erik about getting SGSoundSample to behave correctly, and hopefully that will improve things. I'll update here as/when I get a proper fix for the SimGear code.
Labels: SimGear Sound
View and moderate all "codetickets Discussion" comments posted by this user
Mark all as spam, and block user from posting to "Tickets"
Originally posted by: bre... (code.google.com)@gmail.com
Well, I've traced the issue so far, why not finish it. ;-)
Here's the clean fix for the problem. It's caused by simgear's "SGSampleGroup::update". When a sample's state constantly is "changed" (because sth. keeps updating the sample in each update loop), then SGSampleGroup::update never ever checked if the sample had already stopped playing by itself.
The attached patch reorders the last two conditions. It now first checks if a sample has already stopped playing, before checking if there's sth to update - which is useless for a stopped sample anyway...
It also fixes two other places where the "is_playing" state would not be updated correctly, by adding two additional "stop()" calls. These are not related or required for the problem here though.
I guess you can tell, I actually really like this EGPWS feature :-). Never forget to lower your gear again! ;-) If you wanted some help with the mk-viii module, let me know. It's working beautifully now, but there's some more stuff to do, e.g. gear/flap warnings are a little late for jets. Still needs some tuning...
View and moderate all "codetickets Discussion" comments posted by this user
Mark all as spam, and block user from posting to "Tickets"
Originally posted by: e... (code.google.com)@ehofman.com
Thanks brehmt, your changes are in git now.
View and moderate all "codetickets Discussion" comments posted by this user
Mark all as spam, and block user from posting to "Tickets"
Originally posted by: bre... (code.google.com)@gmail.com
Alas! I'm really sorry guys, but my patch broke something else. It added "sample->stop()" to the "SGSampleGroup::stop" method, so that each sample shows the correct state when the group is stopped.
At some points Flightgear stops and restarts the entire sample group containing the looping background/engine noise. But it does not restart the individual (looping) samples in the group. So now the background noise dies when resetting the sim or changing aircraft location...
You could argue who's in error here. But I suggest to revert my change to line 263 (patch attached), as it wasn't really necessary for the problem above anyway. Probably avoids a lot of hassle. Never change s.th. unless you really need to...
Thorsten
View and moderate all "codetickets Discussion" comments posted by this user
Mark all as spam, and block user from posting to "Tickets"
Originally posted by: e... (code.google.com)@ehofman.com
Ok, no problem. Sometimes these things happen. Thanks for the fix, it's in git.
View and moderate all "codetickets Discussion" comments posted by this user
Mark all as spam, and block user from posting to "Tickets"
Originally posted by: bre... (code.google.com)@gmail.com
I only see the first patch in git. Maybe double-check the second (removing "sample->stop()" from "SGSampleGroup::stop"). Maybe a git problem...
View and moderate all "codetickets Discussion" comments posted by this user
Mark all as spam, and block user from posting to "Tickets"
Originally posted by: zakalawe@mac.com
Fixed, huge thanks to Thorsten for tracking this down and fixing it.
Status: Fixed
View and moderate all "codetickets Discussion" comments posted by this user
Mark all as spam, and block user from posting to "Tickets"
Originally posted by: bre... (code.google.com)@gmail.com
(No comment was entered for this change.)
Status: Temp
View and moderate all "codetickets Discussion" comments posted by this user
Mark all as spam, and block user from posting to "Tickets"
Originally posted by: bre... (code.google.com)@gmail.com
(No comment was entered for this change.)
Status: Fixed
View and moderate all "codetickets Discussion" comments posted by this user
Mark all as spam, and block user from posting to "Tickets"
Originally posted by: gijsrooy
(No comment was entered for this change.)
Labels: Milestone-2.4.0