#62 In some cases terrasync with built-in subversion calls will lock directories

[Anonymous]

Originally created by: j...@flygarna.se

What steps will reproduce the problem?
1. Build terrasync with subversion built-in
2. Run terrasync and break it when it starts to sync.
3. Rerun terrasync
4. You might need to repeat 2 and 3 a few times.
5. terrasync will start complaining about locked directories.

What is the expected output? What do you see instead?

#> /path/to/terrasync -p 5500 -d /path/to/flightgear/data/Scenery-TerraSync
Airports/K ... failed:
Working copy
'/Users/jari/projects/osd/fg/flightgear/data/Scenery-TerraSync/Airports/K'
locked
Airports/L ... done
Airports/M ... ^C

I expect to see the report for Airports/L for each synchronized directory.

What version of the product are you using? On what operating system?

fg CVS February 8 2010 2200 GMT on Mac OS X 10.6.2 (64bit)

Please provide any additional information below.

The problem is that terragear does not catch signals and clean up svn calls
in progress and consequently the directory affected will be locked for
subsequent subversion calls. terrasync should be made more robust wrt
subversion locks.

The current work around is to change to the locked directory and issue 'svn
cleanup'. This will remove subversion locks.

The issue has recently been discussed in the fg-devel mailing list

http://www.mail-archive.com/flightgear-devel@lists.sourceforge.net/msg25662.html
http://www.mail-archive.com/flightgear-devel@lists.sourceforge.net/msg26183.html

[Anonymous]

Originally posted by: pedromor...@gmail.com

(No comment was entered for this change.)

Labels: terrasync

[Anonymous]

Originally posted by: zakalawe@mac.com

This should be easy to fix - anyone care to propose a patch?

Cc: zakalawe
Status: Accepted

[Anonymous]

Originally posted by: j...@flygarna.se

I think this issue was partially resolved by Alex Perry and friends back in February 2010, see http://www.mail-archive.com/flightgear-devel@lists.sourceforge.net/msg26715.html

I made a quick test on my currently broken flightgear set up where I can run terrasync only. It looks like terrasync now exits gracefully (no svn locks) when terrasync is interrupted during svn updates. This is obviously true when terrasync makes calls to an external svn binary but also when terrasync uses built-in svn support. However, I think the functionality needs to be improved somewhat.

Currently a Ctrl-C interrupt of terrasync will spawn a clean termination of terrasync, among other things terrasync will gracefully terminate outstanding svn tasks. If another interrupt is issued during the termination process, the svn WC may end up in a locked state. I think this is acceptable.

I normally terminate terrasync with a 'killall terrasync', i.e., a SIGTERM. Of some reason this signal is not catched in terrasync.cxx for non-Microsoft environments. I added SIGTERM to terrasync.cxx as outlined in the patch file and now terrasync terminates gracefully wrt svn.

[Anonymous]

Originally posted by: zakalawe@mac.com

I'm not a signals expert, but Alex certainly is, so this worries me - if he left SIGTERM out, presumably he had a good reason. I shall see if he can explain!

[Anonymous]

Originally posted by: zakalawe@mac.com

Alex okay-ed this change, I'll commit it when I have a spare moment, today or tomorrow.

[Anonymous]

Originally posted by: zakalawe@mac.com

Fix pushed in
http://gitorious.org/fg/flightgear/commit/793fee679eef2f9d6f1dc98103950dd386ab576e

Status: Fixed

[Anonymous]

Originally posted by: bre...@gmail.com

(No comment was entered for this change.)

Status: Temp

[Anonymous]

Originally posted by: bre...@gmail.com

(No comment was entered for this change.)

Status: Fixed