#398 Menubar - Help > Help opens strange path when including space character

[Anonymous]

Originally created by: yoshimat... (code.google.com)@gmail.com

*What steps will reproduce the problem?*
1. Install fgfs with setup installer with default path (C:\Program Files\FlightGear 2.4.0rc4).
2. Start fgfs, click Help > Help in menubar.
3. Browser opens three URLs with invalid path name:
file:///C:/Program
http://www.files.com/  <-- Wow, there exist!
http://2.4.0rc4/data/Docs/index.html

*What is the expected output? What do you see instead?*
I expected file:///C:/Program%20Files/FlightGear%202.4.0rc4/data/Docs/index.html.

*Any output in the console (black window)?*
No.

*What FlightGear version are you using (when using GIT version, please
mention date)?*
2.4.0rc4

*What operating system and graphics card?*
Windows XP, Firefox 5.0.1

*Please provide any additional information below or as attachment (Avoid
expiring external links, such as to imageshack/pastebin/...).*

Maybe path parser is needed in fgfs, but I'm not sure.

===
From this line, I'll report another issue about documents included in 2.4.0rc4.
I should write them to devel mailing list, but I have some trouble my mail client, sorry.

== data/Docs/index.html ==
1. "The Complete User's Guide" links to InstallGuide/html/getstart.html, but html version of the Manual is not included.

2. "subscribing" link to http://mail.flightgear.org/mailman/listinfo/flightgear-users is obsolete.
http://www.flightgear.org/mail.html or https://lists.sourceforge.net/lists/listinfo/flightgear-users would be better.

== data/Docs/getstart.pdf ==
When I translated Chapter 1 to Chapter 3 (3.5.2) of the Manual 2.0.0, I found typos and took a memo with some comments.

Please have a look at v2.0.0 section in:
http://flightgear.jpn.org/wiki/index.php?comment_on_manual

I believe the section number and quoted contents in wiki are as same as the latest Manual (Aug. 7, 2011) in:
http://mapserver.flightgear.org/getstart.pdf

[Anonymous]

Originally posted by: bre... (code.google.com)@gmail.com

Thanks Toshi, again very good reports!

@Stuart, Martin: Can you take care of the manual corrections? And should data/Docs/index.html link to the PDF instead - or should the html manual be part of the base package?

I'll see what I can do about the white-space issue with the "help" menu item...

Labels: Documentation GUI
Cc: stuart_d...@yahoo.co.uk goo...@mgras.net
Status: Accepted

[Anonymous]

Originally posted by: goo...@mgras.net

Even though some of the phrases are unreadable to me (foreign characters), the comment page looks like a valuable ressource to me ! Any chance to have a unified diff against the current LaTeX source code (or maybe even better a merge request) ?
BTW, it was decided not to ship the HTML with the packaged releases any more and since I'm tired of the battle with Curt wrt. maintaing web server content, I think we'd limit our focus on the PDF version until a reasonable solution has been found for the main website. Feel free to link data/Docs/index.html to the PDF.

[Anonymous]

Originally posted by: bre... (code.google.com)@gmail.com

@Martin: ok. The PDF is already linked too - but we need to remove the HTML link then.

[Anonymous]

Originally posted by: bre... (code.google.com)@gmail.com

Well, white-spaces do work on Linux. Seems broken for Windows only. Problem is the function "helpCb" in GUI/gui_funcs.cxx which contains a Windows-specific line:
snprintf(browserParameter, 1024, "file:///%s", win32_name);

It might work to replace this by:
snprintf(browserParameter, 1024, "<file:///%s>", win32_name);
or
snprintf(browserParameter, 1024, "\"file:///%s\"", win32_name);

Otherwise some magic URL-encoding method is required (which replaces all kinds of special-characters with their hex-codes like " "=>"%20". Most probably there is a Windows library/function which provides this...

Would someone running Windows take care of this? Frederic? Torsten?

Cc: frbo...@gmail.com cumuluni...@gmail.com

[Anonymous]

Originally posted by: bre... (code.google.com)@gmail.com

@Martin, I've fixed the "getting_started" link in index.html (also other HTML issues):
http://www.gitorious.org/fg/fgdata/commit/ebafc513eed11f942a92091ca26c1e3ee9ce3ebc

S.o else needs to work on "Open browser" on Windows problem and LaTeX issues.

[Anonymous]

Originally posted by: frbo... (code.google.com)@gmail.com

Should be fixed, please test

Status: Testing

[Anonymous]

Originally posted by: bre... (code.google.com)@gmail.com

(No comment was entered for this change.)

Labels: Milestone-2.4.0

[Anonymous]

Originally posted by: yoshimat... (code.google.com)@gmail.com

Fred, thank you for your quick fix to the white-space issue.
Replacing fgfs.exe with the latest one (Jenkins > Windows-release #213), I confirmed that my web browser correctly opened file:///C:/Program%20Files/FlightGear%202.4.0rc4/data/Docs/index.html.
I think the white-space issue has been resolved.

Martin, making diff of TeX source is difficult for me, sorry.
Mainly because I can't confirm TeX output with no TeX environment in my machine.
Secondly, I don't know the answer for some points written in wiki.
For example, I have no idea about:
> You can download aircraft from
> http://www.flightgear.org/Downloads/aircraft/index.shtml
Current URL is http://www.flightgear.org/Downloads/aircraft-2.0.0/.
Curt may be the only person who knows the comming URL for 2.4.0 aircrafts.

Thorsten, thanks for your update of Docs/index.html.
I noticed one more minor typo.
> Users should consider subscribing to the flightgear-users@flightgear.org mailing list.
--> Correct address is flightgear-users@lists.sourceforge.net

-Toshi

[Anonymous]

Originally posted by: goo...@mgras.net

> Martin, making diff of TeX source is difficult for me, sorry.

Ah, that's ok, I was under the impression that you're sufficiently familiar with TeX. Anyhow, we'll get this done, just maybe not within the next week ....

[Anonymous]

Originally posted by: bre... (code.google.com)@gmail.com

Right, thanks Toshi-san for spotting this. Mail address is also adapted:
http://www.gitorious.org/fg/fgdata/commit/ad66771336c4c72626a6420085e1f594ef686c17

Btw, "grep" also found some outdated addresses in getstarted.pdf (link to mail archive, outdated since 2005. Yuk! ;-)). So, if someone was going to work on the Tex things...

[Anonymous]

Originally posted by: goo...@mgras.net

The most recent HTML version of The Manual is now available at:
http://mapserver.flightgear.org/getstart/

[Anonymous]

Originally posted by: yoshimat... (code.google.com)@gmail.com

Martin, thank you for preparing HTML version of the Manual dated Aug. 15, 2011.
I hope Curt also update the Manual linked from http://www.flightgear.org/.

Although my comments to the Manual 2.0.0 was not reflected to the Manual 2.4.0, I have a will to translate (slowly) version 2.4.0 of the Manual to Japanese in FlightGear JP Wiki.
Next time, I want to make an effort to report sufficiently before the release date.
When I complete making comments to the Manual again, then I'll report to devel mailing list.

Following picture shows 3.3.1 "Launching from the command line" in current HTML version of the Manual.
As unintended tilde (~) was not seen in the PDF version, I attached just for my memorize.

-Toshi

[Anonymous]

Originally posted by: goo...@mgras.net

The PDF is correct:
SET FG_HOME="c:\Program Files\FlightGear"

Apparently there's something to consider wrt. the HTML writer, I'm trying to find a 'portable' solution which doesn't break PDF output ....

Curt's copy of the HTML manual is out of date and I suspect it won't be updated any more. Instead I hope/guess that the link will be changed.

[Anonymous]

Originally posted by: cumuluni... (code.google.com)@gmail.com

Looks like it's fixed - issue closed.

OT: needed a google account for my android, all good (short) names were already taken,
that's why my user-id has changed :-P

cumulunimbuscalvus aka Torsten

Cc: -cumuluni...@gmail.com
Status: Done