#303 YASim solver relies on wrong data

[Anonymous]

Originally created by: kanto... (code.google.com)@gmail.com

*What steps will reproduce the problem?*
The internal solver of YASim which computes the drag and lift coefficients does not use the values set in XML input data for approach fuel, cruise fuel and cruise glide angle.
Despite providing a way for the user to input these values, they are not used at runtime. In the case of fuel, hardcoded values of 0.2 and 0.5 are used, and in the case of cruise glide angle the value from approach is used (simple oversight).
Sensible values input by user do not heavily modify the solution, however in some cases there could be more than a marginal difference between the expected result and the output.
I have attached a patch.

*What version of the product are you using (when using GIT version, please
mention date or Hudson build number)?*

Latest GIT build

*Please provide any additional information below or as attachment (Avoid
expiring external links, such as to imageshack/pastebin/...).*

Diff attached

[Anonymous]

Originally posted by: kanto... (code.google.com)@gmail.com

Sorry, the diff attached was wrong, here is the correct one.

[Anonymous]

Originally posted by: bre... (code.google.com)@gmail.com

Patch looks good - and the issue obvious enough to me, so I'll push this one straight to git. Thanks!

Labels: YASIM FDM
Status: Accepted

[Anonymous]

Originally posted by: bre... (code.google.com)@gmail.com

Pushed:
http://www.gitorious.org/fg/flightgear/commit/7f5a0e35184677c21f1eafdfbe6438eb644cdbff

Status: Testing

[Anonymous]

Originally posted by: gijsrooy

Looks like a nice patch, please re-open if it fails.

Status: Fixed