FlightGear - Flight Simulator / Tickets / #2643 Instruments-3d/cdu: route editing and bugfixes (patch available)

Anonymous - 2021-08-25

assigned_to: Gijs
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2021-08-26

Attachments has changed:

Diff:

--- old +++ new @@ -1 +0,0 @@ -cdu.patch (299.0 kB; text/x-patch)
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2021-08-26

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2021-08-26

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

summary: Instruments-3d/cdu: small bugs (patch available) --> Instruments-3d/cdu: route editing and bugfixes (patch available)
Description has changed:

Diff:

--- old
+++ new
@@ -1,9 +1,10 @@
 I noticed a few problems with the CDU, which seems like it could be a promising cockpit UI for the Route Manager.

-1. The buttons on the right of the screen work in Nasal, but are missing their hotspots in the 3D.
-2. The input string still accepts input and is displayed when `instrumentation/cdu/serviceable` is false.
-3. The 3D model uses the old `lightmap` effect, and I have been unable to make the keys light up regardless of graphics settings.
+1. Only the first 5 waypoints of the route are accessible.
+2. The buttons on the right of the screen work in Nasal, but are missing their hotspots in the 3D.
+3. The input string still accepts input and is displayed when `instrumentation/cdu/serviceable` is false.
+4. The 3D model uses the old `lightmap` effect, and I have been unable to make the keys light up regardless of graphics settings.

-I have added the blanking of input line to Nasal, also converted the main loop to using `maketimer()` instead of `settimer()` and fixed the formatting of flap retract height on the takeoff ref screen.
+I have changed the Nasal file to support editing the whole route, added the blanking of input line to Nasal, also converted the main loop to using `maketimer()` instead of `settimer()` and fixed the formatting of flap retract height on the takeoff ref screen.

 The 3D model now uses `model-combined-deferred` effect. I had to move the backlight calculation to the Nasal because the modern lightmap effect only supports one property per lightmap, and I have added the missing hotspots. Additionally I have  improved the shading  by switching to smooth shading and splitting the sharp edges.

Attachments has changed:

Diff:

--- old
+++ new
@@ -0,0 +1 @@
+cdu.patch (320.1 kB; text/x-patch)

Anonymous - 2021-08-26

Here is the new patch that enables the editing of the whole route.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2021-08-26

Also leg distances in "RTE1 LEGS" seem to be moved down by one place. I will try to fix tomorrow.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2021-08-26

Actually, done, also fixed wrong indices for the speed on RTE1 LEGS.

cdu.patch

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

James Turner - 2021-08-26

Hmm, you might want to check if anything is different on my 737 branch, since that's where I have done most of the CDU work. Especially, all the pages are loaded dynamically, so they can be different for each aircraft.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous - 2021-08-26
  
  Is it a branch of fgdata or of the aircraft?
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

James Turner - 2021-08-26

The pages are in the aircraft, but the core CDU changes are all pushed to FGData, I think - will check. Note this is the version in cdu2

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

legoboyvdlp - 2021-08-26

Wouldn't it be worth at least maintaining the old one, which is used in a number of aircraft (even though it doesn't work particularly well)? As far as I know, the new one is only, for now, used in the 737-800, and only in the forked version!

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2021-08-26

Thanks, James, I will try to make as many parts of the interface that I have changed more similar to cdu2 as I can.

Indeed, legoboyvdlp, I think it would make sense to maintain the simplified CDU that directly drives Route Manager, so that the aircraft which have no proper FMC developed yet can have a placeholder and avoid having to use the dialog. Maybe we can disable performance and weight pages until the aircraft developer populates them with the aircraft's data and explicitly enables, instead of relying on internal properties of FDM etc?

Would it be ok if I also fix the shading of the cdu2 3d model and make the brightness knob on both a bit taller?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

James Turner - 2021-08-26

I migth be confused what new and old mean here. The one in cdu/ is not touched by me, and I don't know which aircraft use it. The one in cdu2/ is my code (but also modified by Gijs), and what's in FGData on next is approximately what is used by the current (fairly advanced) 737NG CDU on my fork.

Seperately it would be good to merge my 737-800 changes back but I don't know if that is actually possible. But that would also mean we had an example of how the CDU Nasal is supposed to integrate between the aircraft and the core files.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2021-08-26

I think by "new" Lego meant cdu2.

So far I've only been able to make the backlight work the same as cdu2, it seems that their interfaces are too different, and reconciling them would need a more changes to the old than I was prepared to make. And the more I edit the code the more I see that it would need a major overhaul to approach any realism -- I should probably try to make generic pages for cdu2 instead of trying to expand cdu.

But at least it's mostly bug-free now. ^^

Last edit: Anonymous 2021-08-26

cdu.patch

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

James Turner - 2021-08-29

@legoboyvdlp okay, now i understand it's the old one :) So, I don't know which aircraft use it, but I think we can apply this to FGData/next and see how it goes? If everyone agrres, then Michael please go ahead with that.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Instruments-3d/cdu: route editing and bugfixes (patch available)

FlightGear Flight Simulator: free open-source multiplatform flight sim

Milestone

Searches

Help

#2643 Instruments-3d/cdu: route editing and bugfixes (patch available)

Discussion