Originally created by: gijsrooy
Originally owned by: gijsrooy
No usefull report yet, but I occasionaly see these errors when I'm on multiplayer.
Nasal getValue: property /ai[0]/models[0]/multiplayer[2]/position[0]/global-x[0] is NaN
Nasal runtime error: props.getValue() would have read NaN
at D:/FlightGear/data/Nasal/props.nas, line 26
called from: D:/FlightGear/data/Nasal/multiplayer.nas, line 277
called from: D:/FlightGear/data/Nasal/multiplayer.nas, line 268
called from: D:/FlightGear/data/Nasal/multiplayer.nas, line 313
called from: D:/FlightGear/data/Nasal/multiplayer.nas, line 190
called from: D:/FlightGear/data/Nasal/globals.nas, line 100
FGMultiplayMgr::MP_ProcessData: Domain error
View and moderate all "codetickets Discussion" comments posted by this user
Mark all as spam, and block user from posting to "Tickets"
Originally posted by: bre... (code.google.com)@gmail.com
Nice, MP injected NaN values... Would be good to catch/prevent such NaNs before multimgr.cxx writes these to the property tree - to avoid a single bogus FG session to distribute its local problem via MP to everyone else.
Cc: zakalawe
View and moderate all "codetickets Discussion" comments posted by this user
Mark all as spam, and block user from posting to "Tickets"
Originally posted by: bre... (code.google.com)@gmail.com
(No comment was entered for this change.)
Summary: NaN error messages in multiplayer mode
View and moderate all "codetickets Discussion" comments posted by this user
Mark all as spam, and block user from posting to "Tickets"
Originally posted by: zakalawe@mac.com
Catching NaN values coming from MP should be pretty easy to do.
Labels: fixable
Status: Accepted
View and moderate all "codetickets Discussion" comments posted by this user
Mark all as spam, and block user from posting to "Tickets"
Originally posted by: bre... (code.google.com)@gmail.com
I'll add the necessary NaN checks in the multiplaymgr.
James, you shouldn't have any difficulty in merging the few extra lines with your pending MP update.
Status: Triaged
View and moderate all "codetickets Discussion" comments posted by this user
Mark all as spam, and block user from posting to "Tickets"
Originally posted by: bre... (code.google.com)@gmail.com
Done. James, please check the patch (another 2.2.0 candidate).
http://www.gitorious.org/fg/flightgear/commit/feab53b4621cafec0739f6e2fe63607bbc5b9b8b
I'll also drop the former check in Nasal/multiplayer.nas. The check there is obsolete now, since NaN values cannot enter Nasal any longer (they now trigger the new run-time error shown above). And the new check in multiplaymgr.cxx is much better anyway.
Status: Testing
View and moderate all "codetickets Discussion" comments posted by this user
Mark all as spam, and block user from posting to "Tickets"
Originally posted by: bre... (code.google.com)@gmail.com
... and this one:
http://www.gitorious.org/fg/flightgear/commit/5268b3c6ede60689b351475fe8cbc0dfd41053b4
View and moderate all "codetickets Discussion" comments posted by this user
Mark all as spam, and block user from posting to "Tickets"
Originally posted by: zakalawe@mac.com
Change looks good to me, I agree it should go to the release branch.
View and moderate all "codetickets Discussion" comments posted by this user
Mark all as spam, and block user from posting to "Tickets"
Originally posted by: bre... (code.google.com)@gmail.com
(No comment was entered for this change.)
Status: Fixed
View and moderate all "codetickets Discussion" comments posted by this user
Mark all as spam, and block user from posting to "Tickets"
Originally posted by: bre... (code.google.com)@gmail.com
(No comment was entered for this change.)
Status: Temp
View and moderate all "codetickets Discussion" comments posted by this user
Mark all as spam, and block user from posting to "Tickets"
Originally posted by: bre... (code.google.com)@gmail.com
(No comment was entered for this change.)
Status: Fixed
View and moderate all "codetickets Discussion" comments posted by this user
Mark all as spam, and block user from posting to "Tickets"
Originally posted by: bre... (code.google.com)@gmail.com
(No comment was entered for this change.)
Labels: Milestone-2.4.0