#2013 TerraSync down not download all tiles specified in some cases

[Peter Duda]

Coordinates bounding box for download is not correctly checked against when walking into next level subdirectory under Terrains, etc.

As directory at that level represent big tile of 10 times 10 degrees and is checked as single coordinate against download bounding box, if that coordinate is not within bounding box, directory is not walked into, even if some part of data stored in subdirectories within should be downloaded.

Such directory mus be checked different way - overlap of download bounding box and directory big tile bounding box must be checked and if case of overlapd, directory must be walked into and subdirectories processed.

Calling 'terrasync.py --only-subdir Terrain --top 47 --bottom 47 --left 18 --right 18' results in:
Directories skipped because of the specified boundaries:
...
/Terrain/e010n40
...
because coordinate 40N010E is not within 47N018E to 48N019E box

Correct way is to create bound box 40N010E to 50N020E and check overlap with download bounding box of 47N018E to 48N019E.

[Peter Duda]

I've created attached patch to solve this ticket for me.

[James Turner]

I've asked some people who know the script to look into this - thanks for the report.

[xDraconian]

Reproducible as of 2018-Sep-26.
terrasync.py fails to download terrain unless --left and --bottom are at a 10-degree boundary.

Furthermore, the wrong bucket is downloaded when using a bounding box.
python3 terrasync.py --only-subdir Terrain --top 41 --bottom 40 --left 10 --right 11
retrieved = e011n41
It appears that the upper-right coordinate was utilized instead of the lower-left.

[xDraconian]

Bug resolved.
Fix was based on patch provided by Peter Duda.