From: Will E. <wes...@gm...> - 2017-11-13 11:07:05
|
On Monday, 13 November 2017, 5:21 pm +0800, Kang-Che Sung <exp...@gm...> wrote: > Now, I'm not sure if I'm allowed to make pull requests that modifies the > scanopt interface to match one of the GNU interfaces above. A pull request is a pull request. The usual metric is that the more you change, the more important it has to be. > My questions are these: > 1. Will a pull request that may modify the optspec_t structure and the option.c > entries be accepted? Depends. I have nothing against such a pull request as such. > 2. If accepts such a pull request, should I keep the description field in > optspec_t and the scanopt_usage() function when possible, or is it fine to > remove them altogether? (I personally prefers to remove, as they > unnecessary complicates the translation.) When you make the pull request, just explain why you do what you do and why that's better -- if it's not obvious from "why". -- Will Estes Flex Project Maintainer wes...@gm... https://github.com/westes/flex |