From: Will E. <wes...@gm...> - 2015-12-04 15:20:44
|
Thanks for your report. Can you submit a patch or pull request for the below? On Friday, 4 December 2015, 4:16 pm +0100, Akim Demaille <ak...@lr...> wrote: > Hi, > > I’m happy to see that the C++ code is renovated. While at it, please > s/struct yy_buffer_state/yy_buffer_state/g, the struct keyword is absolutely > useless, and clutters the flex-lexer.hh file. > > Also, really, FLEX_STD is, IMHO, very useless. Just spread std:: everywhere. > std:: is 17 years old! > > Actually, reading the generated code, one reads: > > /* The contents of this function are C++ specific, so the () macro is not used. > * This constructor simply maintains backward compatibility. > * DEPRECATED > */ > yyFlexLexer::yyFlexLexer( FLEX_STD istream* arg_yyin, FLEX_STD ostream* arg_yyout ): > yyin(arg_yyin ? arg_yyin->rdbuf() : std::cin.rdbuf()), > yyout(arg_yyout ? arg_yyout->rdbuf() : std::cout.rdbuf()) > { > ctor_common(); > } > > /* The contents of this function are C++ specific, so the () macro is not used. > */ > yyFlexLexer::yyFlexLexer( std::istream& arg_yyin, std::ostream& arg_yyout ): > > one has std::, the other has FLEX_STD. So compliance with std:: is already > assumed. > > > ------------------------------------------------------------------------------ > Go from Idea to Many App Stores Faster with Intel(R) XDK > Give your users amazing mobile app experiences with Intel(R) XDK. > Use one codebase in this all-in-one HTML5 development environment. > Design, debug & build mobile apps & 2D/3D high-impact games for multiple OSs. > http://pubads.g.doubleclick.net/gampad/clk?id=254741911&iu=/4140 > -- > Flex-help mailing list > Fle...@li... > https://lists.sourceforge.net/lists/listinfo/flex-help -- Will Estes Flex Project Maintainer wes...@gm... https://github.com/westes/flex |