Re: [Flex-devel] Char macro

[Mighty Jo <mig...@gm...>]

I made the text replacements (Char -> unsigned char) in a branch and it
tested clean with

> git clean -xdf
> ./autogen.sh; ./configure; make && make distcheck

So I submitted PR#21 for consideration.

On Fri, Nov 27, 2015 at 9:32 PM, Mighty Jo <mig...@gm...> wrote:

> I agree with Michael's suggestion to use "unsigned char" directly.  Looks
> like the Char macro is vestigial, left over from the days of 7-bit
> character support.
>
> 'grep -rn "\bChar\b" ' turns up about 80 lines that would need edits.
>
> On Mon, Nov 16, 2015 at 11:43 AM, Michael McConville <mm...@my...>
> wrote:
>
>> Hi, everyone.
>>
>> The flex codebase uses the macro Char, an alias for unsigned char. Both
>> the capitalization and the name are idiosyncratic and can be confusing.
>> For example, I found a few ctype function argument type issues (see
>> https://www.securecoding.cert.org/confluence/x/fAs) recently, and Char
>> obfuscated some.
>>
>> I think two good options are:
>>
>>  * remove Char and use unsigned char directly, or
>>  * rename Char to u_char (the BSDs already use this idiom)
>>
>> Thoughts?
>>
>> Thanks,
>> Michael
>>
>>
>> ------------------------------------------------------------------------------
>> Presto, an open source distributed SQL query engine for big data,
>> initially
>> developed by Facebook, enables you to easily query your data on Hadoop in
>> a
>> more interactive manner. Teradata is also now providing full enterprise
>> support for Presto. Download a free open source copy now.
>> http://pubads.g.doubleclick.net/gampad/clk?id=250295911&iu=/4140
>> _______________________________________________
>> Flex-devel mailing list
>> Fle...@li...
>> https://lists.sourceforge.net/lists/listinfo/flex-devel
>
>