Re: [Flex-devel] Status of the patch for bug 182?

[Will E. <wes...@gm...>]

Looks like you should be in src/ for that patch to apply.. So, from where you were:

$ cd src/
 $ patch < ../patchfile

As you can see from the lines that start with - and +, that patch is changing linker options (the *LDFLAGS variables in Makefile.am) for the libfl variants that get built. Apparently it needs the version info and since building this way was new to me, I likely copied whatever the manual said to do.

On Tuesday, 10 November 2015,  1:27 am -0800, Damian Rouson <da...@so...> wrote:

> 
> ________________________________
> Damian Rouson, Ph.D., P.E.
> President, Sourcery Institute
> http://www.sourceryinstitute.org
> +1-510-600-2992 (mobile)
> 
> > On Nov 9, 2015, at 7:41 AM, Will Estes <wes...@gm...> wrote:
> > 
> > That's the default medium priority assigned by sourceforge. I'll move this one up in the queue, though. Also note that there's a lot of work that has happened in flex's git tree that has not been released yet. I've got a handful of pull requests to work through in the next few days and I'll add #182 to that list as well. At that point I'll make a release.
> 
> Thanks for the update. 
> 
> > 
> > Can you also verify that the proposed patch works for you on OSX? I don't have an OSX machine to test on and the symptom doesn't manifest on my linux box.
> 
> 
> I’ve always had difficulty applying patches.  Here’s what the patch gives me, but I won’t be surprised if I’m doing something wrong:
> 
> localhost:flex-2.5.39 rouson$ cat file.patch
> --- Makefile.am copy    2014-10-27 16:41:46.000000000 +0900
> +++ Makefile.am 2014-10-27 16:48:56.000000000 +0900
> @@ -73,13 +73,13 @@
>     libmain.c \
>     libyywrap.c
> 
> -libfl_la_LDFLAGS = -no-undefined -version-info @SHARED_VERSION_INFO@
> +libfl_la_LDFLAGS = -version-info @SHARED_VERSION_INFO@
> 
>  libfl_pic_la_SOURCES = \
>     libmain.c \
>     libyywrap.c
> 
> -libfl_pic_la_LDFLAGS = -no-undefined -version-info @SHARED_VERSION_INFO@
> +libfl_pic_la_LDFLAGS = -version-info @SHARED_VERSION_INFO@
> 
>  noinst_HEADERS = \
>     flexdef.h \
> localhost:flex-2.5.39 rouson$ patch -p0 < file.patch 
> patching file Makefile.am
> Hunk #1 FAILED at 73.
> 1 out of 1 hunk FAILED -- saving rejects to file Makefile.am.re
> 
> If you can provide instructions about how to apply the patch, I’ll be glad to try again.
> 
> D

-- 
Will Estes
wes...@gm...