Re: [Flex-devel] Pull Request #16

[Mighty Jo <mig...@gm...>]

On Sun, Nov 8, 2015 at 11:04 AM, Will Estes <wes...@gm...> wrote:
>
> > > > Make all & check weren't rebuilding all of the scanners in tests/
> when
> > > > files in src/, skel.c for example, had changed. Several of the tests'
> > > built
>
> the test suite tests the built version of flex in the build tree. So, in
> the case where flex source files change but flex has not been rebuilt, the
> correct thing to do is to test using the currently built version of flex.
> The test suit should consider "flex" as a black box that has to be tested.
>

Got it.  I usually end up building libtool convenience libraries and making
my tests depend on those.  Depending on the build binary does the same
thing in this case.  Nifty.  I've submitted PR#19 that does just that.


>
> > > > sources weren't listed as such and 'make clean' didn't reach them so
> I
> > > kept
> > > > having to delete them manually or touch the .l's to rebuild them.  I
> made
> > > > sure they were all listed in the right automake vars to let make
> clean
> > > > them.  I didn't fiddle with making them depend on skel.c yet.
>
> I'll look for the patch on this. If you're correct, then it's definitely a
> bug.
>
>
That was PR#18 for the google record.


> > >
> > > Oh, sorting out dependencies, that's different--and awesome. Thanks.
> > > That's likely an easy change to incorporate by the way.
> > >
> >
> > Haha, that's what I was thinking.  I'll still work on separating out the
> > change set.  I need the practice with Git.
>
> Branches are your friend ;) Ping me if you need help on this.
>
>
Figured it out. Git is much better about this kind of thing than SVN.  Love
the squash and fixup options when rebasing.

<snip>


> > The autoconf archive provides ax_cxx_compile_stdcxx_11.m4 for the c++11
> feature test.  I've used it and
> > it works well if we want to go that route.
>
> I'm becoming more a fan of the autoconf archive, yes.


It's certainly better than the macros I write myself.


> That being said, this sort of discussion should be on list so others can
> weigh in as they have expertise and so google can tape the show for the
> future.
>
>
Cool beans!

-Joe