flex-devel — development of flex itself

Re: [Flex-devel] texi2dvi dependency

[Mighty Jo <mig...@gm...>]

I just sent up PR#23 which patches configure.ac to support both texi2dvi
and gtexi2dvi.  It fixes similar issues with the bison and help2man
programs as well.

On Wed, Dec 2, 2015 at 6:38 PM, Michael McConville <mm...@my...>
wrote:

> Mighty Jo wrote:
> > I didn't initially have the tools to build the docs installed. It's
> > likely users won't either.
> >
> > I think it's reasonable to pull the pdf and html out of the repository
> > since they're build products, but I'd leave them in the distro
> > tarball.
>
> Yeah, I think most package maintainers will find the additional
> dependencies unfortunate.
>

Re: [Flex-devel] texi2dvi dependency

[Will E. <wes...@gm...>]

I'll dig more into automake.

On Wednesday,  2 December 2015, 10:52 am -0500, Michael McConville <mm...@my...> wrote:

> Will Estes wrote:
> > You know, as a work around, I bet you could touch doc/flex.pdf after
> > configure runs.
> 
> This is indeed hacky, but works. It's probably clean enough to use for
> now. Thanks!
> 
> As for long-term solutions: maybe 'make doc' can be a separate,
> non-default command that makes documentation other than man pages.
> 
> ------------------------------------------------------------------------------
> Go from Idea to Many App Stores Faster with Intel(R) XDK
> Give your users amazing mobile app experiences with Intel(R) XDK.
> Use one codebase in this all-in-one HTML5 development environment.
> Design, debug & build mobile apps & 2D/3D high-impact games for multiple OSs.
> http://pubads.g.doubleclick.net/gampad/clk?id=254741911&iu=/4140
> _______________________________________________
> Flex-devel mailing list
> Fle...@li...
> https://lists.sourceforge.net/lists/listinfo/flex-devel

-- 
Will Estes
wes...@gm...

Re: [Flex-devel] texi2dvi dependency

[Michael M. <mm...@my...>]

Will Estes wrote:
> You know, as a work around, I bet you could touch doc/flex.pdf after
> configure runs.

This is indeed hacky, but works. It's probably clean enough to use for
now. Thanks!

As for long-term solutions: maybe 'make doc' can be a separate,
non-default command that makes documentation other than man pages.

Re: [Flex-devel] texi2dvi dependency

[Will E. <wes...@gm...>]

You know, as a work around, I bet you could touch doc/flex.pdf after configure runs.

On Tuesday,  1 December 2015,  6:08 pm -0500, Michael McConville <mm...@my...> wrote:

> Will Estes wrote:
> > Send me the log of the build run, please. You should probably send me
> > the output of this:
> > 
> > $ git clean -xdf && ./autogen.sh && ./configure && TEXI2DVI=gtexi2dvi make
> > 
> > Also, what automake and autoconf versions are you using?
> > 
> > This is sounding like a posting to the automake list as the automake
> > manual documents the variables TEXI2DVI and TEXI2PDF.
> 
> I'll get to the above soon. In a rush at the moment.
> 
> > As a work around, could you alias texi2dvi to expand to gtexi2dvi? I
> > mean, that's ugly, but it might get you through till we can dig up
> > what's up with automake.
> 
> This doesn't work because aliases aren't inherited by subshells.
> 
> Thanks for the help. I'll share more useful information soon.
> 
> ------------------------------------------------------------------------------
> Go from Idea to Many App Stores Faster with Intel(R) XDK
> Give your users amazing mobile app experiences with Intel(R) XDK.
> Use one codebase in this all-in-one HTML5 development environment.
> Design, debug & build mobile apps & 2D/3D high-impact games for multiple OSs.
> http://pubads.g.doubleclick.net/gampad/clk?id=254741911&iu=/4140
> _______________________________________________
> Flex-devel mailing list
> Fle...@li...
> https://lists.sourceforge.net/lists/listinfo/flex-devel

-- 
Will Estes
wes...@gm...

Re: [Flex-devel] texi2dvi dependency

[Will E. <wes...@gm...>]

None of the doc output formats are in version control. They're all .gitignore'd in fact.

I'm not sure that flex.pdf is useful to folks, though.

Thoughts, list?

* Does anyone read the manual in pdf form?

* Would anyone read the manual in html format if it were included in the distribution?

** Single file, node-based or both?

On Tuesday,  1 December 2015,  8:58 pm -0500, Mighty Jo <mig...@gm...> wrote:

> I didn't initially have the tools to build the docs installed. It's likely
> users won't either.
> 
> I think it's reasonable to pull the pdf and html out of the repository
> since they're build products, but I'd leave them in the distro tarball.
> On Dec 1, 2015 8:02 PM, "Will Estes" <wes...@gm...> wrote:
> 
> > On Tuesday,  1 December 2015,  6:08 pm -0500, Michael McConville <
> > mm...@my...> wrote:
> >
> > > > As a work around, could you alias texi2dvi to expand to gtexi2dvi? I
> > > > mean, that's ugly, but it might get you through till we can dig up
> > > > what's up with automake.
> > >
> > > This doesn't work because aliases aren't inherited by subshells.
> > >
> > > Thanks for the help. I'll share more useful information soon.
> >
> > Yeah, I realized that right after I hit send. Grasping at straws and all.
> >
> > Looking at doc/Makefile.am, I'm not sure why I put flex.pdf into the
> > distribution, though. The commit message is unenlightening.
> >
> > I'm not opposed to removing flex.pdf from the distribution. If anything,
> > I'd add the html generated files as that seems more useful to folks.
> >
> > Any thoughts, list?
> >
> > --
> > Will Estes
> > wes...@gm...
> >
> >
> > ------------------------------------------------------------------------------
> > Go from Idea to Many App Stores Faster with Intel(R) XDK
> > Give your users amazing mobile app experiences with Intel(R) XDK.
> > Use one codebase in this all-in-one HTML5 development environment.
> > Design, debug & build mobile apps & 2D/3D high-impact games for multiple
> > OSs.
> > http://pubads.g.doubleclick.net/gampad/clk?id=254741911&iu=/4140
> > _______________________________________________
> > Flex-devel mailing list
> > Fle...@li...
> > https://lists.sourceforge.net/lists/listinfo/flex-devel
> >

> ------------------------------------------------------------------------------
> Go from Idea to Many App Stores Faster with Intel(R) XDK
> Give your users amazing mobile app experiences with Intel(R) XDK.
> Use one codebase in this all-in-one HTML5 development environment.
> Design, debug & build mobile apps & 2D/3D high-impact games for multiple OSs.
> http://pubads.g.doubleclick.net/gampad/clk?id=254741911&iu=/4140

> _______________________________________________
> Flex-devel mailing list
> Fle...@li...
> https://lists.sourceforge.net/lists/listinfo/flex-devel


-- 
Will Estes
Flex Project Maintainer
wes...@gm...
https://github.com/westes/flex

Re: [Flex-devel] texi2dvi dependency

[Mighty Jo <mig...@gm...>]

I didn't initially have the tools to build the docs installed. It's likely
users won't either.

I think it's reasonable to pull the pdf and html out of the repository
since they're build products, but I'd leave them in the distro tarball.
On Dec 1, 2015 8:02 PM, "Will Estes" <wes...@gm...> wrote:

> On Tuesday,  1 December 2015,  6:08 pm -0500, Michael McConville <
> mm...@my...> wrote:
>
> > > As a work around, could you alias texi2dvi to expand to gtexi2dvi? I
> > > mean, that's ugly, but it might get you through till we can dig up
> > > what's up with automake.
> >
> > This doesn't work because aliases aren't inherited by subshells.
> >
> > Thanks for the help. I'll share more useful information soon.
>
> Yeah, I realized that right after I hit send. Grasping at straws and all.
>
> Looking at doc/Makefile.am, I'm not sure why I put flex.pdf into the
> distribution, though. The commit message is unenlightening.
>
> I'm not opposed to removing flex.pdf from the distribution. If anything,
> I'd add the html generated files as that seems more useful to folks.
>
> Any thoughts, list?
>
> --
> Will Estes
> wes...@gm...
>
>
> ------------------------------------------------------------------------------
> Go from Idea to Many App Stores Faster with Intel(R) XDK
> Give your users amazing mobile app experiences with Intel(R) XDK.
> Use one codebase in this all-in-one HTML5 development environment.
> Design, debug & build mobile apps & 2D/3D high-impact games for multiple
> OSs.
> http://pubads.g.doubleclick.net/gampad/clk?id=254741911&iu=/4140
> _______________________________________________
> Flex-devel mailing list
> Fle...@li...
> https://lists.sourceforge.net/lists/listinfo/flex-devel
>

Re: [Flex-devel] texi2dvi dependency

[Will E. <wes...@gm...>]

On Tuesday,  1 December 2015,  6:08 pm -0500, Michael McConville <mm...@my...> wrote:

> > As a work around, could you alias texi2dvi to expand to gtexi2dvi? I
> > mean, that's ugly, but it might get you through till we can dig up
> > what's up with automake.
> 
> This doesn't work because aliases aren't inherited by subshells.
> 
> Thanks for the help. I'll share more useful information soon.

Yeah, I realized that right after I hit send. Grasping at straws and all.

Looking at doc/Makefile.am, I'm not sure why I put flex.pdf into the distribution, though. The commit message is unenlightening.

I'm not opposed to removing flex.pdf from the distribution. If anything, I'd add the html generated files as that seems more useful to folks.

Any thoughts, list?

-- 
Will Estes
wes...@gm...

Re: [Flex-devel] texi2dvi dependency

[Michael M. <mm...@my...>]

Will Estes wrote:
> Send me the log of the build run, please. You should probably send me
> the output of this:
> 
> $ git clean -xdf && ./autogen.sh && ./configure && TEXI2DVI=gtexi2dvi make
> 
> Also, what automake and autoconf versions are you using?
> 
> This is sounding like a posting to the automake list as the automake
> manual documents the variables TEXI2DVI and TEXI2PDF.

I'll get to the above soon. In a rush at the moment.

> As a work around, could you alias texi2dvi to expand to gtexi2dvi? I
> mean, that's ugly, but it might get you through till we can dig up
> what's up with automake.

This doesn't work because aliases aren't inherited by subshells.

Thanks for the help. I'll share more useful information soon.

Re: [Flex-devel] texi2dvi dependency

[Will E. <wes...@gm...>]

On Tuesday,  1 December 2015,  5:19 pm -0500, Michael McConville <mm...@my...> wrote:

> Will Estes wrote:
> > Are you building from the flex distributed 2.6.0 tarball or from the
> > git tree? If the former, that's a bug as you shouldn't need to rebuild
> > that (so I'd need to add something to the distribution). If the
> > latter, seems like automake should be taking care of that -- but it
> > isn't, as you're reporting.
> 
> The git tree.
> 
> I haven't had a chance to look for an autoconf macro yet.
> 
> > Have you tried something like:
> > 
> > TEXI2DVI=gtexi2dvi make
> 
> Yes, but it doesn't work.

Send me the log of the build run, please. You should probably send me the output of this:

$ git clean -xdf && ./autogen.sh && ./configure && TEXI2DVI=gtexi2dvi make

Also, what automake and autoconf versions are you using?

This is sounding like a posting to the automake list as the automake manual documents the variables TEXI2DVI and TEXI2PDF.

As a work around, could you alias texi2dvi to expand to gtexi2dvi? I mean, that's ugly, but it might get you through till we can dig up what's up with automake.

> 
> ------------------------------------------------------------------------------
> Go from Idea to Many App Stores Faster with Intel(R) XDK
> Give your users amazing mobile app experiences with Intel(R) XDK.
> Use one codebase in this all-in-one HTML5 development environment.
> Design, debug & build mobile apps & 2D/3D high-impact games for multiple OSs.
> http://pubads.g.doubleclick.net/gampad/clk?id=254741911&iu=/4140
> _______________________________________________
> Flex-devel mailing list
> Fle...@li...
> https://lists.sourceforge.net/lists/listinfo/flex-devel

-- 
Will Estes
wes...@gm...

Re: [Flex-devel] texi2dvi dependency

[Michael M. <mm...@my...>]

Will Estes wrote:
> Are you building from the flex distributed 2.6.0 tarball or from the
> git tree? If the former, that's a bug as you shouldn't need to rebuild
> that (so I'd need to add something to the distribution). If the
> latter, seems like automake should be taking care of that -- but it
> isn't, as you're reporting.

The git tree.

I haven't had a chance to look for an autoconf macro yet.

> Have you tried something like:
> 
> TEXI2DVI=gtexi2dvi make

Yes, but it doesn't work.

Re: [Flex-devel] texi2dvi dependency

[Will E. <wes...@gm...>]

A clarification, please:

Are you building from the flex distributed 2.6.0 tarball or from the git tree? If the former, that's a bug as you shouldn't need to rebuild that (so I'd need to add something to the distribution). If the latter, seems like automake should be taking care of that -- but it isn't, as you're reporting.

Have you tried something like:

TEXI2DVI=gtexi2dvi make



On Tuesday,  1 December 2015,  3:24 pm -0500, Michael McConville <mm...@my...> wrote:

> Michael McConville wrote:
> > On OpenBSD, I need to use the texi2dvi port because the version in base
> > is too old. The port's binary is named gtexi2dvi. Currently, there seems
> > to be no way to change the texi2dvi binary name used by flex's build
> > system. There's an env var TEXI2DVI set in the Makefile, but it
> > overrides anything in the existing environment.
> > 
> > Of course, I could manually edit Makefile.in or Makefile every time, but
> > that's tedious and prevents me from porting flex.
> > 
> > Is there an easy way to change this behavior?
> 
> Minor correction: this is doc/Makefile.in and doc/Makefile.
> 
> ------------------------------------------------------------------------------
> Go from Idea to Many App Stores Faster with Intel(R) XDK
> Give your users amazing mobile app experiences with Intel(R) XDK.
> Use one codebase in this all-in-one HTML5 development environment.
> Design, debug & build mobile apps & 2D/3D high-impact games for multiple OSs.
> http://pubads.g.doubleclick.net/gampad/clk?id=254741911&iu=/4140
> _______________________________________________
> Flex-devel mailing list
> Fle...@li...
> https://lists.sourceforge.net/lists/listinfo/flex-devel

-- 
Will Estes
wes...@gm...

Re: [Flex-devel] texi2dvi dependency

[Michael M. <mm...@my...>]

Michael McConville wrote:
> On OpenBSD, I need to use the texi2dvi port because the version in base
> is too old. The port's binary is named gtexi2dvi. Currently, there seems
> to be no way to change the texi2dvi binary name used by flex's build
> system. There's an env var TEXI2DVI set in the Makefile, but it
> overrides anything in the existing environment.
> 
> Of course, I could manually edit Makefile.in or Makefile every time, but
> that's tedious and prevents me from porting flex.
> 
> Is there an easy way to change this behavior?

Minor correction: this is doc/Makefile.in and doc/Makefile.

[Flex-devel] texi2dvi dependency

[Michael M. <mm...@my...>]

On OpenBSD, I need to use the texi2dvi port because the version in base
is too old. The port's binary is named gtexi2dvi. Currently, there seems
to be no way to change the texi2dvi binary name used by flex's build
system. There's an env var TEXI2DVI set in the Makefile, but it
overrides anything in the existing environment.

Of course, I could manually edit Makefile.in or Makefile every time, but
that's tedious and prevents me from porting flex.

Is there an easy way to change this behavior?

Thanks,
Mike

Re: [Flex-devel] Index underflow in lex(1)

[Will E. <wes...@gm...>]

Here's the patch as it was applied to the flex tree. It'll go out in the next release.

https://github.com/westes/flex/commit/9ba6e5283efd2fe454d3bc92eca960b3ebd91294




On Monday, 30 November 2015,  4:22 pm -0800, Serguey Parkhomovsky <ser...@gm...> wrote:

> On Mon, Nov 30, 2015 at 06:51:39PM -0500, Will Estes wrote:
> > Awesome. This applies cleanly albeit with fuzz and makes sense.
> > 
> > Could you provide Serguey Parkhomovsky's email address so I can use it when committing the change into git?
> 
> Happy to help. :-)
> 
> The address that I'm sending from right now is OK. As well, I believe
> this patch fixes #193 and #194 in flex's bugtracker.

-- 
Will Estes
wes...@gm...

Re: [Flex-devel] Index underflow in lex(1)

[Will E. <wes...@gm...>]

Much appreciated.

On Monday, 30 November 2015,  4:22 pm -0800, Serguey Parkhomovsky <ser...@gm...> wrote:

> On Mon, Nov 30, 2015 at 06:51:39PM -0500, Will Estes wrote:
> > Awesome. This applies cleanly albeit with fuzz and makes sense.
> > 
> > Could you provide Serguey Parkhomovsky's email address so I can use it when committing the change into git?
> 
> Happy to help. :-)
> 
> The address that I'm sending from right now is OK. As well, I believe
> this patch fixes #193 and #194 in flex's bugtracker.

-- 
Will Estes
wes...@gm...

Re: [Flex-devel] Index underflow in lex(1)

[Will E. <wes...@gm...>]

Awesome. This applies cleanly albeit with fuzz and makes sense.

Could you provide Serguey Parkhomovsky's email address so I can use it when committing the change into git?

On Monday, 30 November 2015,  4:42 pm -0500, Michael McConville <mm...@my...> wrote:

> Serguey Parkhomovsky wrote:
> > On Thu, Nov 26, 2015 at 01:03:22PM -0500, Michael McConville wrote:
> > > This nondeterministically underflows _sf_top_ix, causing a segfault:
> > > 
> > > 	http://www.sccs.swarthmore.edu/users/16/mmcconv1/dump/crash.l
> > > 
> > 
> > Looks like _sf_top_ix always underflows whenever there are extra closing
> > parentheses in the rules section. The nondeterministic behavior is
> > probably heap layout related.
> > 
> > I've taken your suggestion and updated scan.l to give a syntax error
> > when there is an unbalanced parenthesis, which fixes the issue:
> 
> Forwarding to upstream.
> 
> > Index: scan.l
> > ===================================================================
> > RCS file: /cvs/src/usr.bin/lex/scan.l,v
> > retrieving revision 1.12
> > diff -u -p -r1.12 scan.l
> > --- scan.l      19 Nov 2015 23:34:56 -0000      1.12
> > +++ scan.l      30 Nov 2015 21:19:44 -0000
> > @@ -741,7 +741,13 @@ nmstr[yyleng - 2 - end_is_ws] = '\0';  /
> >                      return '(';
> >                  }
> >      "("         sf_push(); return '(';
> > -    ")"         sf_pop(); return ')';
> > +    ")"         {
> > +                    if (_sf_top_ix > 0) {
> > +                        sf_pop();
> > +                        return ')';
> > +                    } else
> > +                        synerr(_("unbalanced parenthesis"));
> > +                }
> >  
> >         [/|*+?.(){}]    return (unsigned char) yytext[0];
> >         .               RETURNCHAR;
> 
> ------------------------------------------------------------------------------
> Go from Idea to Many App Stores Faster with Intel(R) XDK
> Give your users amazing mobile app experiences with Intel(R) XDK.
> Use one codebase in this all-in-one HTML5 development environment.
> Design, debug & build mobile apps & 2D/3D high-impact games for multiple OSs.
> http://pubads.g.doubleclick.net/gampad/clk?id=254741911&iu=/4140
> _______________________________________________
> Flex-devel mailing list
> Fle...@li...
> https://lists.sourceforge.net/lists/listinfo/flex-devel

-- 
Will Estes
wes...@gm...

Re: [Flex-devel] Index underflow in lex(1)

[Michael M. <mm...@my...>]

Serguey Parkhomovsky wrote:
> On Thu, Nov 26, 2015 at 01:03:22PM -0500, Michael McConville wrote:
> > This nondeterministically underflows _sf_top_ix, causing a segfault:
> > 
> > 	http://www.sccs.swarthmore.edu/users/16/mmcconv1/dump/crash.l
> > 
> 
> Looks like _sf_top_ix always underflows whenever there are extra closing
> parentheses in the rules section. The nondeterministic behavior is
> probably heap layout related.
> 
> I've taken your suggestion and updated scan.l to give a syntax error
> when there is an unbalanced parenthesis, which fixes the issue:

Forwarding to upstream.

> Index: scan.l
> ===================================================================
> RCS file: /cvs/src/usr.bin/lex/scan.l,v
> retrieving revision 1.12
> diff -u -p -r1.12 scan.l
> --- scan.l      19 Nov 2015 23:34:56 -0000      1.12
> +++ scan.l      30 Nov 2015 21:19:44 -0000
> @@ -741,7 +741,13 @@ nmstr[yyleng - 2 - end_is_ws] = '\0';  /
>                      return '(';
>                  }
>      "("         sf_push(); return '(';
> -    ")"         sf_pop(); return ')';
> +    ")"         {
> +                    if (_sf_top_ix > 0) {
> +                        sf_pop();
> +                        return ')';
> +                    } else
> +                        synerr(_("unbalanced parenthesis"));
> +                }
>  
>         [/|*+?.(){}]    return (unsigned char) yytext[0];
>         .               RETURNCHAR;

Re: [Flex-devel] Char macro

[Will E. <wes...@gm...>]

Thanks. I'll have a look at the pr.

On Friday, 27 November 2015,  9:44 pm -0500, Mighty Jo <mig...@gm...> wrote:

> I made the text replacements (Char -> unsigned char) in a branch and it
> tested clean with
> 
> > git clean -xdf
> > ./autogen.sh; ./configure; make && make distcheck
> 
> So I submitted PR#21 for consideration.
> 
> On Fri, Nov 27, 2015 at 9:32 PM, Mighty Jo <mig...@gm...> wrote:
> 
> > I agree with Michael's suggestion to use "unsigned char" directly.  Looks
> > like the Char macro is vestigial, left over from the days of 7-bit
> > character support.
> >
> > 'grep -rn "\bChar\b" ' turns up about 80 lines that would need edits.
> >
> > On Mon, Nov 16, 2015 at 11:43 AM, Michael McConville <mm...@my...>
> > wrote:
> >
> >> Hi, everyone.
> >>
> >> The flex codebase uses the macro Char, an alias for unsigned char. Both
> >> the capitalization and the name are idiosyncratic and can be confusing.
> >> For example, I found a few ctype function argument type issues (see
> >> https://www.securecoding.cert.org/confluence/x/fAs) recently, and Char
> >> obfuscated some.
> >>
> >> I think two good options are:
> >>
> >>  * remove Char and use unsigned char directly, or
> >>  * rename Char to u_char (the BSDs already use this idiom)
> >>
> >> Thoughts?
> >>
> >> Thanks,
> >> Michael
> >>
> >>
> >> ------------------------------------------------------------------------------
> >> Presto, an open source distributed SQL query engine for big data,
> >> initially
> >> developed by Facebook, enables you to easily query your data on Hadoop in
> >> a
> >> more interactive manner. Teradata is also now providing full enterprise
> >> support for Presto. Download a free open source copy now.
> >> http://pubads.g.doubleclick.net/gampad/clk?id=250295911&iu=/4140
> >> _______________________________________________
> >> Flex-devel mailing list
> >> Fle...@li...
> >> https://lists.sourceforge.net/lists/listinfo/flex-devel
> >
> >

> ------------------------------------------------------------------------------

> _______________________________________________
> Flex-devel mailing list
> Fle...@li...
> https://lists.sourceforge.net/lists/listinfo/flex-devel


-- 
Will Estes
Flex Project Maintainer
wes...@gm...
https://github.com/westes/flex

Re: [Flex-devel] Char macro

[Mighty Jo <mig...@gm...>]

I made the text replacements (Char -> unsigned char) in a branch and it
tested clean with

> git clean -xdf
> ./autogen.sh; ./configure; make && make distcheck

So I submitted PR#21 for consideration.

On Fri, Nov 27, 2015 at 9:32 PM, Mighty Jo <mig...@gm...> wrote:

> I agree with Michael's suggestion to use "unsigned char" directly.  Looks
> like the Char macro is vestigial, left over from the days of 7-bit
> character support.
>
> 'grep -rn "\bChar\b" ' turns up about 80 lines that would need edits.
>
> On Mon, Nov 16, 2015 at 11:43 AM, Michael McConville <mm...@my...>
> wrote:
>
>> Hi, everyone.
>>
>> The flex codebase uses the macro Char, an alias for unsigned char. Both
>> the capitalization and the name are idiosyncratic and can be confusing.
>> For example, I found a few ctype function argument type issues (see
>> https://www.securecoding.cert.org/confluence/x/fAs) recently, and Char
>> obfuscated some.
>>
>> I think two good options are:
>>
>>  * remove Char and use unsigned char directly, or
>>  * rename Char to u_char (the BSDs already use this idiom)
>>
>> Thoughts?
>>
>> Thanks,
>> Michael
>>
>>
>> ------------------------------------------------------------------------------
>> Presto, an open source distributed SQL query engine for big data,
>> initially
>> developed by Facebook, enables you to easily query your data on Hadoop in
>> a
>> more interactive manner. Teradata is also now providing full enterprise
>> support for Presto. Download a free open source copy now.
>> http://pubads.g.doubleclick.net/gampad/clk?id=250295911&iu=/4140
>> _______________________________________________
>> Flex-devel mailing list
>> Fle...@li...
>> https://lists.sourceforge.net/lists/listinfo/flex-devel
>
>

[Flex-devel] Fwd: Char macro

[Mighty Jo <mig...@gm...>]

I agree with Michael's suggestion to use "unsigned char" directly.  Looks
like the Char macro is vestigial, left over from the days of 7-bit
character support.

'grep -rn "\bChar\b" ' turns up about 80 lines that would need edits.

On Mon, Nov 16, 2015 at 11:43 AM, Michael McConville <mm...@my...>
wrote:

> Hi, everyone.
>
> The flex codebase uses the macro Char, an alias for unsigned char. Both
> the capitalization and the name are idiosyncratic and can be confusing.
> For example, I found a few ctype function argument type issues (see
> https://www.securecoding.cert.org/confluence/x/fAs) recently, and Char
> obfuscated some.
>
> I think two good options are:
>
>  * remove Char and use unsigned char directly, or
>  * rename Char to u_char (the BSDs already use this idiom)
>
> Thoughts?
>
> Thanks,
> Michael
>
>
> ------------------------------------------------------------------------------
> Presto, an open source distributed SQL query engine for big data, initially
> developed by Facebook, enables you to easily query your data on Hadoop in a
> more interactive manner. Teradata is also now providing full enterprise
> support for Presto. Download a free open source copy now.
> http://pubads.g.doubleclick.net/gampad/clk?id=250295911&iu=/4140
> _______________________________________________
> Flex-devel mailing list
> Fle...@li...
> https://lists.sourceforge.net/lists/listinfo/flex-devel

Re: [Flex-devel] yyFlexLexer inheritance issue reports

[Mighty Jo <mig...@gm...>]

Thanks for the pointers.  Between the BUGS file and the notes in to.do/ I
think I understand the complaint.  It's less that inheritance is broken and
more that it's hard to do correctly as things stand.  More extensive
documentation of the C++ scanner will help to some degree.  I'm also
working on some things in my cxx_headers branch that will help.

In any case, the complaint in the BUGS file comes with code so it'll be
easy to write a test, assuming the current tests don't already provide
coverage.  I think the problem was solved by the addition of the
yyFlexLexerOnce guard, but we'll see.


On Wed, Nov 25, 2015 at 12:29 PM, Will Estes <wes...@gm...> wrote:

> Then it was either on the old GNU mailing list or in the old "lex"
> sourceforge project (which iirc is no longer archived online anywhere).
> There's some notes from "lex" project bug reports in the BUGS file in the
> flex code tree though. While that code hasn't changed much, it may well be
> that the inheritence stuff works better now. If you're testing things, then
> the test result rules, of course.
>
> On Wednesday, 25 November 2015, 12:19 pm -0500, Mighty Jo <
> mig...@gm...> wrote:
>
> > Wise words. Git blames John Millaway on 15-FEB-2006 in commit b1da71e.
> > On Nov 25, 2015 9:14 AM, "Will Estes" <wes...@gm...> wrote:
> >
> > > Dunno off the top of my head, honestly.
> > >
> > > Can you git blame the comment and maybe get a time stamp on when that
> > > comment was written?
> > >
> > > On Wednesday, 25 November 2015,  8:50 am -0500, Mighty Jo <
> > > mig...@gm...> wrote:
> > >
> > > > Morning folks,
> > > >
> > > > I'm writing more tests for the c++ scanner. A comment in the source
> says
> > > > you've had reports that the yyFlexLexer macro breaks inheritance.
> Google
> > > > isn't helping me find those reports. Did they come to one of the
> > > listservs?
> > > >
> > > > Thanks!
> > > >
> > > > -Joe
> > >
> > > >
> > >
> ------------------------------------------------------------------------------
> > > > Go from Idea to Many App Stores Faster with Intel(R) XDK
> > > > Give your users amazing mobile app experiences with Intel(R) XDK.
> > > > Use one codebase in this all-in-one HTML5 development environment.
> > > > Design, debug & build mobile apps & 2D/3D high-impact games for
> multiple
> > > OSs.
> > > > http://pubads.g.doubleclick.net/gampad/clk?id=254741551&iu=/4140
> > >
> > > > _______________________________________________
> > > > Flex-devel mailing list
> > > > Fle...@li...
> > > > https://lists.sourceforge.net/lists/listinfo/flex-devel
> > >
> > >
> > > --
> > > Will Estes
> > > Flex Project Maintainer
> > > wes...@gm...
> > > https://github.com/westes/flex
> > >
>
> >
> ------------------------------------------------------------------------------
> > Go from Idea to Many App Stores Faster with Intel(R) XDK
> > Give your users amazing mobile app experiences with Intel(R) XDK.
> > Use one codebase in this all-in-one HTML5 development environment.
> > Design, debug & build mobile apps & 2D/3D high-impact games for multiple
> OSs.
> > http://pubads.g.doubleclick.net/gampad/clk?id=254741551&iu=/4140
>
> > _______________________________________________
> > Flex-devel mailing list
> > Fle...@li...
> > https://lists.sourceforge.net/lists/listinfo/flex-devel
>
>
> --
> Will Estes
> Flex Project Maintainer
> wes...@gm...
> https://github.com/westes/flex
>

[Flex-devel] Index underflow in Flex

[Michael M. <mm...@my...>]

I originally sent this to te...@op..., but it's relevant here too:

---

This nondeterministically underflows _sf_top_ix, causing a segfault:

	http://www.sccs.swarthmore.edu/users/16/mmcconv1/dump/crash.l

The cleanest way to trigger it is:

for i in `jot 1000`
do
	cat crash.l | ./lex -t > /dev/null
done

A backtrace is below.

sf_pop() is the only code that reduces _sf_top_ix. It uses
assert(_sf_top_ix > 0), but that gets removed in the build. Maybe it
should instead include a fatal syntax error, since it implies unbalanced
parens. I don't know why this is nondeterministic, though...

Found with afl. More to come, probably.


Program terminated with signal 11, Segmentation fault.
[...]
583                 if (sf_skip_ws()){
(gdb) bt
#0  0x00000bb0a2436e25 in flexscan () at scan.l:583
#1  0x00000bb0a244120b in yylex () at yylex.c:52
#2  0x00000bb0a242d9cb in yyparse () at parse.c:689
#3  0x00000bb0a2428f40 in readin () at main.c:1446
#4  0x00000bb0a2425cda in flex_main (argc=2, argv=0x7f7ffffc1cd8) at main.c:175
#5  0x00000bb0a2425e58 in main (argc=2, argv=0x7f7ffffc1cd8) at main.c:223
(gdb) p _sf_top_ix
$1 = 18446744073709551615

Re: [Flex-devel] yyFlexLexer inheritance issue reports

[Will E. <wes...@gm...>]

Then it was either on the old GNU mailing list or in the old "lex" sourceforge project (which iirc is no longer archived online anywhere). There's some notes from "lex" project bug reports in the BUGS file in the flex code tree though. While that code hasn't changed much, it may well be that the inheritence stuff works better now. If you're testing things, then the test result rules, of course.

On Wednesday, 25 November 2015, 12:19 pm -0500, Mighty Jo <mig...@gm...> wrote:

> Wise words. Git blames John Millaway on 15-FEB-2006 in commit b1da71e.
> On Nov 25, 2015 9:14 AM, "Will Estes" <wes...@gm...> wrote:
> 
> > Dunno off the top of my head, honestly.
> >
> > Can you git blame the comment and maybe get a time stamp on when that
> > comment was written?
> >
> > On Wednesday, 25 November 2015,  8:50 am -0500, Mighty Jo <
> > mig...@gm...> wrote:
> >
> > > Morning folks,
> > >
> > > I'm writing more tests for the c++ scanner. A comment in the source says
> > > you've had reports that the yyFlexLexer macro breaks inheritance.  Google
> > > isn't helping me find those reports. Did they come to one of the
> > listservs?
> > >
> > > Thanks!
> > >
> > > -Joe
> >
> > >
> > ------------------------------------------------------------------------------
> > > Go from Idea to Many App Stores Faster with Intel(R) XDK
> > > Give your users amazing mobile app experiences with Intel(R) XDK.
> > > Use one codebase in this all-in-one HTML5 development environment.
> > > Design, debug & build mobile apps & 2D/3D high-impact games for multiple
> > OSs.
> > > http://pubads.g.doubleclick.net/gampad/clk?id=254741551&iu=/4140
> >
> > > _______________________________________________
> > > Flex-devel mailing list
> > > Fle...@li...
> > > https://lists.sourceforge.net/lists/listinfo/flex-devel
> >
> >
> > --
> > Will Estes
> > Flex Project Maintainer
> > wes...@gm...
> > https://github.com/westes/flex
> >

> ------------------------------------------------------------------------------
> Go from Idea to Many App Stores Faster with Intel(R) XDK
> Give your users amazing mobile app experiences with Intel(R) XDK.
> Use one codebase in this all-in-one HTML5 development environment.
> Design, debug & build mobile apps & 2D/3D high-impact games for multiple OSs.
> http://pubads.g.doubleclick.net/gampad/clk?id=254741551&iu=/4140

> _______________________________________________
> Flex-devel mailing list
> Fle...@li...
> https://lists.sourceforge.net/lists/listinfo/flex-devel


-- 
Will Estes
Flex Project Maintainer
wes...@gm...
https://github.com/westes/flex

Re: [Flex-devel] yyFlexLexer inheritance issue reports

[Mighty Jo <mig...@gm...>]

Wise words. Git blames John Millaway on 15-FEB-2006 in commit b1da71e.
On Nov 25, 2015 9:14 AM, "Will Estes" <wes...@gm...> wrote:

> Dunno off the top of my head, honestly.
>
> Can you git blame the comment and maybe get a time stamp on when that
> comment was written?
>
> On Wednesday, 25 November 2015,  8:50 am -0500, Mighty Jo <
> mig...@gm...> wrote:
>
> > Morning folks,
> >
> > I'm writing more tests for the c++ scanner. A comment in the source says
> > you've had reports that the yyFlexLexer macro breaks inheritance.  Google
> > isn't helping me find those reports. Did they come to one of the
> listservs?
> >
> > Thanks!
> >
> > -Joe
>
> >
> ------------------------------------------------------------------------------
> > Go from Idea to Many App Stores Faster with Intel(R) XDK
> > Give your users amazing mobile app experiences with Intel(R) XDK.
> > Use one codebase in this all-in-one HTML5 development environment.
> > Design, debug & build mobile apps & 2D/3D high-impact games for multiple
> OSs.
> > http://pubads.g.doubleclick.net/gampad/clk?id=254741551&iu=/4140
>
> > _______________________________________________
> > Flex-devel mailing list
> > Fle...@li...
> > https://lists.sourceforge.net/lists/listinfo/flex-devel
>
>
> --
> Will Estes
> Flex Project Maintainer
> wes...@gm...
> https://github.com/westes/flex
>

Re: [Flex-devel] yyFlexLexer inheritance issue reports

[Will E. <wes...@gm...>]

Dunno off the top of my head, honestly.

Can you git blame the comment and maybe get a time stamp on when that comment was written?

On Wednesday, 25 November 2015,  8:50 am -0500, Mighty Jo <mig...@gm...> wrote:

> Morning folks,
> 
> I'm writing more tests for the c++ scanner. A comment in the source says
> you've had reports that the yyFlexLexer macro breaks inheritance.  Google
> isn't helping me find those reports. Did they come to one of the listservs?
> 
> Thanks!
> 
> -Joe

> ------------------------------------------------------------------------------
> Go from Idea to Many App Stores Faster with Intel(R) XDK
> Give your users amazing mobile app experiences with Intel(R) XDK.
> Use one codebase in this all-in-one HTML5 development environment.
> Design, debug & build mobile apps & 2D/3D high-impact games for multiple OSs.
> http://pubads.g.doubleclick.net/gampad/clk?id=254741551&iu=/4140

> _______________________________________________
> Flex-devel mailing list
> Fle...@li...
> https://lists.sourceforge.net/lists/listinfo/flex-devel


-- 
Will Estes
Flex Project Maintainer
wes...@gm...
https://github.com/westes/flex