Fix Typo for Banned Function `_ftcscat`
Finds vulnerabilities in C/C++ source code
Brought to you by:
dwheeler
diff flawfinder.orig flawfinder
890c890
< "StrCat|StrCatA|StrcatW|lstrcatA|lstrcatW|strCatBuff|StrCatBuffA|StrCatBuffW|StrCatChainW|_tccat|_mbccat|_ftcsat|StrCatN|StrCatNA|StrCatNW|StrNCat|StrNCatA|StrNCatW|lstrncat|lstrcatnA|lstrcatnW":
---
> "StrCat|StrCatA|StrcatW|lstrcatA|lstrcatW|strCatBuff|StrCatBuffA|StrCatBuffW|StrCatChainW|_tccat|_mbccat|_ftcscat|StrCatN|StrCatNA|StrCatNW|StrNCat|StrNCatA|StrNCatW|lstrncat|lstrcatnA|lstrcatnW":
Wow, nice catch! I will definitely fix this. How in the world did you notice it?
Thanks! Actually, a colleague of mine and I were compiling a list of RegEx's for scanning code using the banned functions list you referenced:
That particular function is listed in a table entitled "Banned string concatenation functions and replacements", so we figured it must've been a typo.
Cheers,
Oh, it is definitely a typo. I'm just impressed that you found it.
Fixed in master branch, this will go into the next release. Thanks!