Menu

#21 Fix Typo for Banned Function `_ftcscat`

v1.0 (example)
closed
nobody
typo (1)
5
2019-01-12
2019-01-10
No
diff flawfinder.orig flawfinder
890c890
<     "StrCat|StrCatA|StrcatW|lstrcatA|lstrcatW|strCatBuff|StrCatBuffA|StrCatBuffW|StrCatChainW|_tccat|_mbccat|_ftcsat|StrCatN|StrCatNA|StrCatNW|StrNCat|StrNCatA|StrNCatW|lstrncat|lstrcatnA|lstrcatnW":
---
>     "StrCat|StrCatA|StrcatW|lstrcatA|lstrcatW|strCatBuff|StrCatBuffA|StrCatBuffW|StrCatChainW|_tccat|_mbccat|_ftcscat|StrCatN|StrCatNA|StrCatNW|StrNCat|StrNCatA|StrNCatW|lstrncat|lstrcatnA|lstrcatnW":

Discussion

  • David A. Wheeler

    Wow, nice catch! I will definitely fix this. How in the world did you notice it?

     
    👍
    1
  • Lucas Ramage

    Lucas Ramage - 2019-01-11

    Thanks! Actually, a colleague of mine and I were compiling a list of RegEx's for scanning code using the banned functions list you referenced:

    # For more information on Microsoft banned functions, see:
    # http://msdn.microsoft.com/en-us/library/bb288454.aspx
    

    That particular function is listed in a table entitled "Banned string concatenation functions and replacements", so we figured it must've been a typo.

    Cheers,

     
  • David A. Wheeler

    Oh, it is definitely a typo. I'm just impressed that you found it.

     
  • David A. Wheeler

    Fixed in master branch, this will go into the next release. Thanks!

     
  • David A. Wheeler

    • status: open --> closed
    • private: Yes --> No
     

Log in to post a comment.

MongoDB Logo MongoDB