Menu

Contribution

linuxfun
2024-12-15
2025-02-21
  • linuxfun

    linuxfun - 2024-12-15

    Hi,

    I had a look at flavor and noticed, that is was not current. Current regarding the teavm version used and not current regarding the java version required to build. I got my hands dirty making the required changes to port the project to teavm 0.11.0 and make it possible to build with JDK 17+21. Porting in this case means, that unittests and integration tests work and the example is also runnable again. Given that my work was based on the original authors start of porting to the jakarta-Namespace for Webservice integration, that was also completed.

    I offered the change to the upsteam project:

    https://github.com/matthiasblaesing/teavm-flavour/tree/update-teavm-0.11.0
    https://github.com/konsoletyper/teavm-flavour/pull/78

    But the author indicated, that the upstream project is no longer maintained.

    Before the PR against upstream teavm-flavour, I became aware of this fork, but three things stood out:

    • This fork uses subversion. I noticed this when testing various approaches. Working with git branches, being able to reorder/safe multiple copies and prepare multiple changesets has proven to be a very nice enhancement compared to subversion. Indeed I started with git-svn but then I noticed, that
    • This fork dumped the history of the code. I think it is good to keep history. It is not always necessary, but can give valuable perspective.
    • It is unclear how contributions should work. For git multiple established flows exist, the easiest on github with its trivial fork+PR model.

    Anyway. The I'm willing to contribute the changes to this fork. If necessary I can create a patch from my changes, but I'd like to propose to move this project to git. If I remember correctly sourceforge supports multiple SCMs, git being one. To put my work where my mouth is, I did this:

    This seems to work ok. The integrate-fork branch could become a new master branch.

    I want to be honest, I don't know yet whether I'll be working on this in the long run, but the contribution is offered.

    Greetings

    Matthias

     

    Last edit: linuxfun 2025-01-07
  • Andrew Oliver

    Andrew Oliver - 2025-01-05

    Thank you Matthias! I too want to ensure that Flavour is usable with the latest versions of TeaVM and Java. I published an article here that offers a quick fix for using recent Java versions:

    https://frequal.com/java/EnablingFlavourInJava1117And21.html

    I am working on a major new Flavour feature right now, details coming soon. Once it is ready I will have a chance to look at the changes to make Flavour work with newer version of TeaVM.

     
  • Renato Silva

    Renato Silva - 2025-01-31

    Hi, Andrew!

    I figure out flavour project (from TeaVM) and I liked it's concept. About Matthias's comment, would you be willing to migrate the project to GitHub?

    GitHub is better than SourceForge (SVN) for open-source project management because it offers Git-based version control, better collaboration tools (pull requests, issues, discussions), modern CI/CD integration, and a larger developer community, making contributions and visibility easier.

    GitHub provides superior collaboration features compared to SourceForge (SVN), making it easier for developers to discuss, contribute, review, and manage open-source projects.

    GitHub Issues provide a way to track bugs, feature requests, and improvements with labels, assignees, and milestones. GitHub Projects offer Kanban-style boards for task organization.

    Branching in Git is more flexible than SVN, allowing parallel development without affecting the main codebase.

    Developers can fork a repository, make changes independently, and submit a pull request.

    The "book" could be a github-pages.

    Greetings,

    Renato.

     
  • linuxfun

    linuxfun - 2025-02-07

    The question git vs. subversion is independent of the question github vs. sourceforge.

    Sourceforge can handle projects on git basis, so there is no need to switch hosting.

     
  • linuxfun

    linuxfun - 2025-02-07

    As another note: I'm willing to extract my changes and provide them in any form necessary/helpful (patch or some other type of contribution).

     
    • Andrew Oliver

      Andrew Oliver - 2025-02-08

      Flavour will remain on Sourceforge and svn. Github has negative externalities and git lacks svn's clean, readable revision numbers and sane command line (see https://svnvsgit.com/).

      Patches are welcome. There is a small amount of information here: https://flavour.sourceforge.io/guidelines.html. To generate a diff file, use "svn di" from the top of a trunk copy, then create a bug in Tickets (https://sourceforge.net/p/flavour/tickets/) and attach the patch there.

      Thank you!

       
      • linuxfun

        linuxfun - 2025-02-21
         

Log in to post a comment.

MongoDB Logo MongoDB