Re: [fp-dev] [PATCH] proper use of htmlentities

[NoWhereMan <now...@fl...>]

Naoki Hiroshima wrote:
>> Hello,
>>
>> Current version (0.611) has a chance to garble comment author's name
>> because of incorrect use of htmlentities().  For example, if I filled
>> out my name in Japanese, it never got through as it was and ended up
>> showing garbled characters.  So, this patch is essential for
>> languages other than ISO-8859-1.

Oh! Great. Thank you.
I've been thinking about this issue today. As we finally are supporting 
utf-8 (I would like to just not to support the others...), would 
wp_specialchars() work better? you can find it in 
fp-includes/core/core.wp-formatting.php
I guess it would be even better than the PHP original, as it should do less 
checks. What do you think?

>> By the way, I found that many of files are pretty mess with CRLF and
>>  LF. I am not sure what you are using (probably Windows, eh?) and
>> how this
>> mess happened.  Having LF lines and CRLF lines in a file is little
>> bothersome  :-(

The reason for this mess is an horrible horrible editor on Windows (which
once I used to love, SciTE) which was supposed to handle correctly line 
ends.
but that in fact it doesn't :/ Usually I work on Linux, but ATM I'm working 
with Windows... thank you for the per oneliner. I've got cygwin here, so I 
gave a a dos2unix on all of them. I didn't think about xargs... sometimes I 
just forget the basics :D

>> Thanks,

Thank *you* :)