[flatpack-svn] SF.net SVN: flatpack: [342] trunk/flatpack/src/main/java/net/sf/flatpack

[<be...@us...>]

Revision: 342
          http://flatpack.svn.sourceforge.net/flatpack/?rev=342&view=rev
Author:   benoitx
Date:     2007-08-20 14:49:18 -0700 (Mon, 20 Aug 2007)

Log Message:
-----------
Fix a few PMD and Checkstyle warnings.

Modified Paths:
--------------
    trunk/flatpack/src/main/java/net/sf/flatpack/DataSet.java
    trunk/flatpack/src/main/java/net/sf/flatpack/ParserFactory.java
    trunk/flatpack/src/main/java/net/sf/flatpack/util/FPStringUtils.java
    trunk/flatpack/src/main/java/net/sf/flatpack/xml/XMLRecordElement.java

Modified: trunk/flatpack/src/main/java/net/sf/flatpack/DataSet.java
===================================================================
--- trunk/flatpack/src/main/java/net/sf/flatpack/DataSet.java	2007-08-17 18:59:40 UTC (rev 341)
+++ trunk/flatpack/src/main/java/net/sf/flatpack/DataSet.java	2007-08-20 21:49:18 UTC (rev 342)
@@ -36,7 +36,6 @@
 import java.text.SimpleDateFormat;
 import java.util.Date;
 import java.util.List;
-import java.util.NoSuchElementException;
 import java.util.Properties;
 
 import net.sf.flatpack.ordering.OrderBy;

Modified: trunk/flatpack/src/main/java/net/sf/flatpack/ParserFactory.java
===================================================================
--- trunk/flatpack/src/main/java/net/sf/flatpack/ParserFactory.java	2007-08-17 18:59:40 UTC (rev 341)
+++ trunk/flatpack/src/main/java/net/sf/flatpack/ParserFactory.java	2007-08-20 21:49:18 UTC (rev 342)
@@ -244,7 +244,8 @@
      *            The File can be wrapped in a "new FileReader(File)"
      * @return PZParser
      */
-    Parser newDelimitedParser(final File pzmapXML, final File dataSource, final char delimiter, final char qualifier, final boolean ignoreFirstRecord);
+    Parser newDelimitedParser(final File pzmapXML, final File dataSource, final char delimiter, final char qualifier, 
+            final boolean ignoreFirstRecord);
 
     /**
      * Constructs a new DataSet using the PZMAP XML file layout method. This is

Modified: trunk/flatpack/src/main/java/net/sf/flatpack/util/FPStringUtils.java
===================================================================
--- trunk/flatpack/src/main/java/net/sf/flatpack/util/FPStringUtils.java	2007-08-17 18:59:40 UTC (rev 341)
+++ trunk/flatpack/src/main/java/net/sf/flatpack/util/FPStringUtils.java	2007-08-20 21:49:18 UTC (rev 342)
@@ -5,7 +5,11 @@
  * 
  * @author Jakarta Commons
  */
-public class FPStringUtils {
+public final class FPStringUtils {
+    private FPStringUtils() {
+        
+    }
+    
     /**
      * <p>Checks if a String is whitespace, empty ("") or null.</p>
      *

Modified: trunk/flatpack/src/main/java/net/sf/flatpack/xml/XMLRecordElement.java
===================================================================
--- trunk/flatpack/src/main/java/net/sf/flatpack/xml/XMLRecordElement.java	2007-08-17 18:59:40 UTC (rev 341)
+++ trunk/flatpack/src/main/java/net/sf/flatpack/xml/XMLRecordElement.java	2007-08-20 21:49:18 UTC (rev 342)
@@ -113,13 +113,13 @@
     }
 
     /**
-     * @param columns
+     * @param columnsToUse
      *            The columns to set.
      * @param p
      *          PZParser being used.  Can be null.
      */
-    public void setColumns(final List columns, final Parser p) {
-        this.columns = columns;
+    public void setColumns(final List columnsToUse, final Parser p) {
+        this.columns = columnsToUse;
         this.columnIndex = ParserUtils.buidColumnIndexMap(columns, p);
     }
 


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.