[Pzfilereader-svn] SF.net SVN: pzfilereader: [170] trunk/PZFileReader/src/main/java/net/sf/ pzfilereader/util/ParserUtils.java

[<zep...@us...>]

Revision: 170
          http://svn.sourceforge.net/pzfilereader/?rev=170&view=rev
Author:   zepernick
Date:     2006-11-04 08:39:57 -0800 (Sat, 04 Nov 2006)

Log Message:
-----------
modified performance for strip methods per Benoits suggestions

Modified Paths:
--------------
    trunk/PZFileReader/src/main/java/net/sf/pzfilereader/util/ParserUtils.java

Modified: trunk/PZFileReader/src/main/java/net/sf/pzfilereader/util/ParserUtils.java
===================================================================
--- trunk/PZFileReader/src/main/java/net/sf/pzfilereader/util/ParserUtils.java	2006-11-04 16:05:34 UTC (rev 169)
+++ trunk/PZFileReader/src/main/java/net/sf/pzfilereader/util/ParserUtils.java	2006-11-04 16:39:57 UTC (rev 170)
@@ -826,19 +826,21 @@
      * @param value
      * @return String
      */
-    public static String stripNonLongChars(String value){
-        final char[] charString = value.toCharArray();
+    public static String stripNonLongChars(final String value) {
         final StringBuffer newString = new StringBuffer();
         
-        for (int i = 0; i < charString.length; i++) {
-            if (charString[i] >= '0' && charString[i] <= '9' || charString[i] == '-') {
-                newString.append(charString[i]);
+        for (int i = 0; i < value.length(); i++) {
+            final char c = value.charAt(i);
+            if (c >= '0' && c <= '9' || c == '-') {
+                newString.append(c);
             }
         }
         // check to make sure we do not have a single length string with
         // just a minus sign
-        if (newString.length() == 0 || (newString.length() == 1 && newString.toString().equals("-"))) {
-            newString.append("0");
+        final int sLen = newString.length();
+        final String s = newString.toString();
+        if (sLen == 0 || (sLen == 1 && s.equals("-"))) {
+           return "0";
         }
         
         return newString.toString();
@@ -851,19 +853,20 @@
      * @param value
      * @return String
      */
-    public static String stripNonDoubleChars(String value){
-        final char[] charString = value.toCharArray();
+    public static String stripNonDoubleChars(final String value) {
         final StringBuffer newString = new StringBuffer();
         
-        for (int i = 0; i < charString.length; i++) {
-            if (charString[i] >= '0' && charString[i] <= '9' || charString[i] == '-'
-                    || charString[i] == '.') {
-                newString.append(charString[i]);
+        for (int i = 0; i < value.length(); i++) {
+            final char c = value.charAt(i);
+            if (c >= '0' && c <= '9' || c == '-'
+                    || c == '.') {
+                newString.append(c);
             }
         }
-        if (newString.length() == 0 || (newString.length() == 1 && newString.toString().equals("."))
-                || (newString.length() == 1 && newString.toString().equals("-"))) {
-            newString.append("0");
+        final int sLen = newString.length();
+        final String s = newString.toString();
+        if (sLen == 0 || (sLen == 1 && s.equals(".")) || (sLen == 1 && s.equals("-"))) {
+            return "0";
         }
         
         return newString.toString();


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.