[Pzfilereader-svn] SF.net SVN: pzfilereader: [126] trunk/PZFileReader/src/test/java/net/sf/ pzfilereader/parserutils/ParserUtilsSplitLineTest.java

[<be...@us...>]

Revision: 126
          http://svn.sourceforge.net/pzfilereader/?rev=126&view=rev
Author:   benoitx
Date:     2006-10-26 08:50:17 -0700 (Thu, 26 Oct 2006)

Log Message:
-----------
Added a couple of whacky tests, some fail (on purpose); Paul could you check what results you expect and create a few more?
Thanks

Modified Paths:
--------------
    trunk/PZFileReader/src/test/java/net/sf/pzfilereader/parserutils/ParserUtilsSplitLineTest.java

Modified: trunk/PZFileReader/src/test/java/net/sf/pzfilereader/parserutils/ParserUtilsSplitLineTest.java
===================================================================
--- trunk/PZFileReader/src/test/java/net/sf/pzfilereader/parserutils/ParserUtilsSplitLineTest.java	2006-10-26 14:04:40 UTC (rev 125)
+++ trunk/PZFileReader/src/test/java/net/sf/pzfilereader/parserutils/ParserUtilsSplitLineTest.java	2006-10-26 15:50:17 UTC (rev 126)
@@ -59,7 +59,7 @@
     }
 
     /**
-     * Test without any line breaks
+     * Test with any line breaks
      * 
      */
     public void testLineBreaks() {
@@ -70,7 +70,7 @@
 
             final String txtToParse = UnitTestUtils.buildDelimString(DELIMITED_DATA_WITH_BREAKS, d, q);
 
-            final List splitLineResults = ParserUtils.splitLine(txtToParse.toString(), d, q);
+            final List splitLineResults = ParserUtils.splitLine(txtToParse, d, q);
 
             // check to make sure we have the same amount of elements which were
             // expected
@@ -82,25 +82,51 @@
                 assertEquals("Data Element Value Does Not Match (d = " + d + " q = " + q + ")", DELIMITED_DATA_WITH_BREAKS[j],
                         (String) splitLineResults.get(j));
             }
-
         }
     }
 
     /**
      * Test to make sure we get the correct amount of elements for malformed
      * data
-     * 
-     * @param args
      */
     public void testMalformedData() {
         final List splitLineResults = ParserUtils.splitLine(DELIMITED_BAD_DATA, ',', '\"');
 
         assertEquals("Expecting 2 Data Elements From The Malformed Data", 2, splitLineResults.size());
+    }
 
+    /**
+     * Test some extreme cases
+     */
+    public void testSomeExtremeCases() {
+        check("\"a,b,c\"", ',', '\"', new String[] { "a,b,c" });
+        check("\"a,b\",\"c\"", ',', '\"', new String[] { "a,b", "c" });
+        check("a,b,c", ',', '\"', new String[] { "a", "b", "c" });
+        check("  a,b,c", ',', '\"', new String[] { "a", "b", "c" });
+        check("  a,b,c", ',', '\"', new String[] { "a","b","c" });
+        
+        // what would you expect of these ones?
+        check("a\",b,c", ',', '\"', new String[] { "a", "b", "c" });
+        check("\"  a,b,c\"", ',', '\"', new String[] { "a,b,c" });
+        check("  a, b ,c ", ',', '\"', new String[] { "a","b","c" });
+
+        // Paul... please put some more whacky stuff here...
+
     }
 
+    private void check(final String txtToParse, final char delim, final char qualifier, final String[] expected) {
+        final List splitLineResults = ParserUtils.splitLine(txtToParse, delim, qualifier);
+
+        assertEquals(
+                "Did Not Get Amount Of Elements Expected (d = " + delim + " q = " + qualifier + ") txt [" + txtToParse + "]",
+                expected.length, splitLineResults.size());
+
+        for (int i = 0; i < expected.length; i++) {
+            assertEquals("expecting...", expected[i], splitLineResults.get(i));
+        }
+    }
+
     public static void main(final String[] args) {
         junit.textui.TestRunner.run(ParserUtilsSplitLineTest.class);
     }
-
 }


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.