Re: [Flamerobin-devel] Database menu reworked

[Michael H. <mg...@gm...>]

On 16.05.2011 15:18, Nando Dessena wrote:

> I think it can stay there and that it should have a confirmation request
> that cannot be deactivated. BTW, the generic confirmation message used
> until now is not suitable for databases. I have committed a version that
> works for me. Have a look.

OK, then let's leave it there.

> Ok. I have to say that on my Win7 I don't see any underlines in the menu
> captions.

That's probably because you have have "Hide underlined letters for 
keyboard navigation until I press the Alt key" checked in the Display 
Effects dialog.

> BTW, what is the rationale behind the ellipsis (...) after some menu
> command captions and not others?

If there are ellipses left (like for Database Preferences) they should 
probably all be removed as outdated.  The relevant section on when to 
use them (from the Windows Interface Guidelines) is: 
<http://msdn.microsoft.com/en-us/library/aa974176.aspx#punctuation> and 
in the linked sections.  I don't think we have many commands where they 
would be appropriate.

> And anyway, couldn't any of these go to the property page?

These are commands that operate on a service connection, not on a 
database connection, and that may actually disconnect the database (the 
shutdown command), in which case the property page would auto-close.  I 
do also think that they would be more discoverable if available outside 
the property page, but I've no strong feelings about that.  If you think 
they should go into the property page I can implement that.  Note 
however that they will open their own frames, as the sweep and shutdown 
commands can be time-consuming and will block, so they need to be 
executed in a background thread.

Thanks

-- 
Michael Hieke