#1 Flack-2.0.4 Edit Tags patch

[pigiron]

First of all, a big thanks for creating/maintaining this great application. I use it frequently. Also, sometimes I receive FLAC files that already contain Vorbis comment field metadata, and I'll use Flack to repair/modify them.

I found that if I edit a preexisting comment field using either the "Edit TITLE field of all files one at a time" or the "Edit a custom field of all files one at time" menu options, what actually occurs is that the field is added instead of edited. So the result is two comment fields of the same type being stored internally in the file. At least this occurs with version 1.2.1 of the FLAC libraries/utilities. I did not test this problem with any other FLAC versions.

I created this patch to version 2.0.4 of Flack to remove the existing field being edited (if any) before adding the new data when using those two menu options. I noticed that the code was setting the "overwrite" variable to "yes" when using those options, but it appears to not be used in those circumstances.

I've beat on the changes using all the EDIT TAGS options without receiving any errors, and it seems to work with no ill effects. But it's certainly possible that there's some problems down in the cracks somewhere; so further testing would be advised.

[pigiron]

Flack-2.0.4 Edit Tags Patch

[Jamie Nguyen]

Thank you for the feedback pigiron, it's very much appreciated. I am glad you are finding good use for this script.

Thank you also for taking the time to send a patch. I will look into this as soon as possible.