#44 Encoder::Stream::set_metadata() broken

1.3.0
closed-accepted
nobody
None
5
2015-10-03
2011-04-09
Anonymous
No

*NEVER* use C-style casts in C++. Switching it to a 'static_cast', which is what was meant by the writer, leads to a compile error. As it was written, the cast maps to a 'reinterpret_cast'. metadata[i] needed to be dereferenced first.

And my friends tell me I'm being pedantic by using C++ casts...

Discussion

  • Comment has been marked as spam. 
    Undo

    You can see all pending comments posted by this user  here

    Anonymous - 2011-04-09

    fix stupid casting

     
  • Ulrich Klauer

    Ulrich Klauer - 2013-04-06

    This found its way into 1.3.0 (commit 1649c4ab3c08d95fb1056d73d8809fa77d4976dc).

     
  • Erik

    Erik - 2015-10-03
    • status: open --> closed-accepted
    • Group: --> 1.3.0
     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:

JavaScript is required for this form.





No, thanks