#485 Flac versions 1.33/34 ignore the "--keep-foreign-metadata" option when unpacking

[megaslowpoke]

Flac versions 1.33/34 ignore the "--keep-foreign-metadata" option when unpacking when these saved blocks contain a 24-bit header in the old format.

Apparently this is related to a fix in version 1.33: "When converting to WAV, use WAVEFORMATEXTENSIBLE when bits per second is not 8 or 16 (erikd)." which is performed without taking into account the restoration of the saved original header.

Example: "flac -d --keep-foreign-metadata file_24bit_in_old_wav.flac" encoded with version 1.34 with "--keep-foreign-metadata" option:
- on version 1.33/34 and older will not restore the saved title,
- version 1.32 with the same file - everything will work correctly.

[Martijn van Beurden]

Do you have an example file? I'm unable to reproduce this. I tried compressing an old format 24-bit file with a cue chunk to FLAC, restoring it to WAVEFORMATEXTENSIBLE kept the cue chunk.

[megaslowpoke]

Yes, sorry, I completely forgot to add, here for example:
https://soundcloud.com/professorkliq/chasing-time-pk-remix
Button "More" => "Download file"

How to reproduce, compress:
"flac.134 --keep-foreign-metadata --no-padding --best --verify"
Now unpack with different versions:
"flac.132 -d --keep-foreign-metadata"
"flac.134 -d --keep-foreign-metadata"

Unpacked 134: will be with a different header.