#402 metaflac shouldn’t ERROR out on lines longer than 65536 characters

[Nikolai Weibull]

Metaflac shouldn’t ERROR out on lines longer than 65536 characters. Native Instruments’ Traktor writes a lot of data to FLAC files in a comment called TRAKTOR4 that’s often much longer than 65536 characters. I’d be willing to concede that Traktor shouldn’t be storing its data in a BASE64-encoded blob, but I’d still expect metaflac to respect the 32-bit limit on each comment’s value’s length.

[Martijn van Beurden]

As far as I know, that 65536 character limit is imposed by Windows, not by anything metaflac is limiting, so this is not something that is fixable.

[Nikolai Weibull]

I see no such limits mentioned in

http://msdn.microsoft.com/en-us/library/c37dh6kf.aspx?ppud=4

I’m referring to the line array in

http://flac.cvs.sourceforge.net/viewvc/flac/flac/src/metaflac/operations_shorthand_vorbiscomment.c?revision=1.17&view=markup

line 287 and fgets on line 306.

[Martijn van Beurden]

No, but it is a limitation when TRAKTOR tries to pass it to metaflac AFAIK

http://blogs.msdn.com/b/oldnewthing/archive/2003/12/10/56028.aspx

Oh, and BTW, that's an old repository. You should look here: https://git.xiph.org/?p=flac.git

[Nikolai Weibull]

I’m not passing it through the command line, I’m using --import-tags-from and a file. Sorry, I should have made this clear, but I did say “lines” in my original bug report and I linked to the relevant code in my previous message.