FLAC-Free Lossless Audio Codec / Bugs / #258 Fix some pointer initialisations

#258 Fix some pointer initialisations

Milestone: 1.3.0

Status: closed-works-for-me

Owner: Josh Coalson

Labels: libFLAC (59)

Priority: 1

Updated: 2013-08-20

Created: 2007-03-09

Creator: Markus Elfring

Private: No

Pointers should not be initialised by the function "calloc" if they are a member of a bigger data structure. Would you like to deal with an internal representation that is not all-bits-0?
http://c-faq.com/null/varieties.html

I recommend to assign a "0" to data elements like "buffer" in the functions "FLAC__bitreader_new" and "FLAC__bitwriter_new" separately.
http://flac.cvs.sourceforge.net/flac/flac/src/libFLAC/bitreader.c?revision=1.6&view=markup
http://flac.cvs.sourceforge.net/flac/flac/src/libFLAC/bitwriter.c?revision=1.8&view=markup

Are assignments for the data element "words" in the functions "FLAC__bitreader_init" and "FLAC__bitwriter_init" unnecassary in this context?

Discussion

Josh Coalson - 2007-03-15

priority: 5 --> 1

assigned_to: nobody --> jcoalson

status: open --> open-accepted
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Ralph Giles - 2013-08-20

This is a pretty common idiom these days, but I forwarded the issue to the mailing list for further discussion. Please follow up there.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Ralph Giles - 2013-08-20

status: open-accepted --> closed-works-for-me

Group: --> 1.3.0
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Fix some pointer initialisations

Group

Searches

Help

#258 Fix some pointer initialisations

Discussion