#186 Unknown AIFF chunk printout

closed-fixed
4
2014-08-27
2005-08-23
No

flac__encode_aif() has a potential crashing bug with printf.
AIFF chunk names are not zero-terminated, so calling printf with
%s is not correct.

encode.c:488

flac__utils_printf(stderr, 1, "%s: WARNING: skipping unknown
chunk '%s'\n", encoder_session.inbasefilename, chunk_id);

should be something like:

flac__utils_printf(stderr, 1, "%s: WARNING: skipping unknown
chunk '%c%c%c%c'\n", encoder_session.inbasefilename,
chunk_id[0], chunk_id[1], chunk_id[2], chunk_id[3]);

... or chunk_id could be defined as chunk_id[5] and the zero-
terminating char could be manually added to make printf happy.

Discussion

  • Josh Coalson

    Josh Coalson - 2005-08-26
    • assigned_to: nobody --> jcoalson
    • status: open --> open-accepted
     
  • Josh Coalson

    Josh Coalson - 2005-08-29

    Logged In: YES
    user_id=78173

    fixed in CVS, thanks.

     
  • Josh Coalson

    Josh Coalson - 2005-08-29
    • status: open-accepted --> open-fixed
     
  • Josh Coalson

    Josh Coalson - 2005-09-03
    • priority: 5 --> 4
     
  • Josh Coalson

    Josh Coalson - 2006-05-26
    • status: open-fixed --> closed-fixed
     

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks