Re: [Firebird-devel] The last of the "no effect" warning/errorfixes.

[Mark O'D. <mar...@lu...>]

Ann Harrison wrote:

> At 05:24 PM 8/26/00 +1000, Mark O'Donohue wrote:
>
> >
> >Changed to:
> >
> >                    STUFF (name_len);
> >                    for (; c = *name++, name_len--;)
> >                        STUFF (c);
>
> My preference, when a for loop degenerates to its exit
> condition is to change loop types.

I'd agree, and so did Geoff.  I was just being touchy, becuase I haven't
actually coded in pure C for about 6 yrs, and even when I did, I can't
actually remember actually using the "," operator.  I now have reserected
my ancient "A book on C" and "C a Reference manual" (including
draft-proposed ansi standards - so its the newer copy)  and now have them
beside me, although the more I go, the more it IS all comming back to me.

I'll redo them tonight, since we all seem to agree on it.

>
> >In dudley/parse.c
> >
> >static FUNCARG parse_function_arg (
> >     FUNC        function,
> >     USHORT      *position)
> >{
> >...
> >
> >KEYWORD (KW_BY);
> >LEX_token();
>
> The lexeme "by" is used in the GDL (groton data language) in
> two ways:  a column can be COMPUTED [BY] an expression and a
> function parameter can be passed [BY] {VALUE | REFERENCE ...}
>
> The wrong macro is used here.  It should be MATCH (KW_BY) which
> is the way to skip a noise word.

Will also change - thanks, I got a gdml manual section from Helen, but
couldn't find "by" as a keword in the portion that she had given me.


Cheers

Mark