Re: [Firebird-devel] The last of the "no effect" warning/error fixes.

[Geoffrey C. S. <ge...@se...>]

On Sat, 26 Aug 2000, Mark O'Donohue wrote:

> In burp/backup.e
> 
>                    STUFF (name_len);
>                    for (; c = *name++, name_len--;)
>                        STUFF (c);

I personally don't ever see the need for anything of the form

	for (; statement ;)

when using a nice 'while' will yeild less semicolon clutter, but then I
suppose I don't find 'for (; statement ;)' as cute as some people.  ;)

> Another in burp/backup.e
> 
> Changed to:
> 
>         for (rp = field->fld_ranges, n = field->fld_dimensions;  n;
> rp+=2, n--)

After just glancing at this (and the other posting), the change looks
good.  It appears that the semantics of fld_dimensions is the length of
fld_ranges.  The two lines from restore.e really cinched that (and are
much easier to look at):

            end_ranges = fld_ranges + 2 * field->fld_dimensions;
            for (range = fld_ranges; range < end_ranges; range += 2)

Keep up the good work.  I'll contribute more after September comes around,
when I'm not spending 12 hours a day in the office.  :)

Geoff

-- 
Geoffrey C. Speicher                     Tel: (570)803-0535 x1701
ge...@se...               Fax: (570)803-0536
Software Engineering Associates, Inc.    http://www.sea-incorporated.com/