Re: [Firebird-net-provider] Re: How to CREATE DATABASE using .Net FB Provider

[Carlos G. A. <car...@te...>]

Hello:

> I've been looking at the source code :-)
> 
> I see that you use an explicit ';' to split batch commands. This is
> essentially the same problem that the ISQL SET TERM command solves.
> 
> Here's a proposed modification to FbCommand.cs that adds a CommandTerminator
> property to allow the user to set the command terminator to something other
> than semi-colon:
> 
> // added these fields
> 
> 		private string terminator = ";" ;
> 		private char[] terminatorChars = { ';' } ;
> 
> // new property
> 
> 		public string CommandTerminator
> 		{
> 			get { return terminator ; }
> 			set
> 			{
> 				if ( terminator != value )
> 				{
> 					terminator = value ;
> 					terminatorChars = value.ToCharArray() ;
> 				}
> 			}
> 		}

Well in first place i think this is not needed.

But what are people toughts to add this for 1.1 release ??

( actual branch is feature closed, and after RC2 i'm thinking in open a 
new developement branch for 1.1 version of the provider with the 
modifications needed to run with .Net Framework 1.1 too )


> // modified CommandText
> 
> 		/// <include file='xmldoc/fbcommand.xml'
> path='doc/member[@name="P:CommandText"]/*'/>
> 		public string CommandText
> 		{
> 			get
> 			{
> 				return commands[actualCommand] == null ? "" : commands[actualCommand];
> 			}
> 			set
> 			{
> 				if (statement != null && commandText != value && commandText !=
> String.Empty)
> 				{
> 					statement.DropStatement();
> 				}
> 
> 				commandText		= value;
> 				commands		= commandText.Split(terminatorChars);
> 				actualCommand	= 0;
> 			}
> 		}

This piece of code do not match with actual CVS sources :) , i ask any 
more :) are you sure you are working with latest CVS sources ??




-- 
Best regards

Carlos Guzmán Álvarez
Vigo-Spain

"No tengo dones especiales.Sólo soy apasionadamente curioso"
Albert Einstein, científico.