Re: AW: [Firebird-net-provider] Normal or retained commit/rollback of transactions

[<car...@te...>]

Hello:

> I propose the standard behavior should be like the MS providers.
> But what do you think about the normal/retaining problem?
>
> I looked at the documentation of the SqlTransaction class for MSSQLServer.
> They implemented savepoints within transactions by introducing a
> non-IDbTransaction method Save(string savepoint) and overloaded Commit and
> Rollback with version that accept these savepoints. However standard
> behavior is BeginTransaction(), Commit() or Rollback().


As i know savepoints are implemented on FB 1.5, can be a good idea to 
implement a Save(string savepointName) on FbTransaction ??

> What about building a similar solution: BeginTransaction(), Commit(bool
> retaining) or Rollback(bool retaining). Standard Commit() / Rollback() 
> call
> these methods with retaining=false. The only thing, I'm not sure about is,
> whether it should be necessary to call BeginTransaction() after a
> Commit/Rollback(retaining=true). I tend to prefer not to call
> BeginTransaction() again.


I have no problem in add these two methods as overloaded methods for 
Commit and Rollback but possible can be better to implement savepoints.

Comments are welcome on this issue :)

> I included the changes from yesterday as diff -u now.


Thanks very much this makes more easy to me to apply patches :) .



Best regards
Carlos Guzmán Álvarez
Vigo-Spain