Re: [Firebird-odbc-devel] Re: Two questions

[<car...@ho...>]

Hello:

It´s a goog idea i will made it and send to you


Best regards
Carlos G.A.
Vigo-España

Paul Reeves wrote:
> Carlos G.A. wrote:
>  >
>  >
>  > 2. I have more modifications for the SQLGetTypeInfo function ( i send
>  >  the files ), with this modifications an application can create
>  > tables and make selects with the information returned by this
>  > function.
>  >
> 
> 
> You have added hard coded values to TypesResultSet.cpp - for instance:
> 
> 
> #define BLOB(type,code,prefix,suffix)
>  type,code,2147483647,prefix,suffix,NULL,NULLABLE,CASE_SENSITIVE,
>  UNSEARCHABLE,NOT_NUMERIC,NOT_NUMERIC,NOT_NUMERIC,type,UNSCALED,UNSCALED
> 
> I believe values such as 2147483647 should be constants. It will make
> the code easier to read. The programmer's intention will become clearer
> especially for values that depend upon a system or platform
> implementation that is liable to change in the future.
> 
> Can you replace the values with the constants you mean them to be? They
> should already be declared in existing header files.
> 
> 
> Paul