Re: [Firebird-odbc-devel] Problems with last CVS sources

[Paul R. <pr...@ib...>]

Carlos Guzm=E1n =C1lvarez wrote:
> Hello:
>=20
> 1. Im testing the last CVS sources under Visual Foxpro and the driver=20
> crashes when V.Foxpro made a call to
> SQLPrepare and a call to SQLNumResultcols ( almost to me in my test ),=20
> the problem is in this block of code:
>=20
>     if (!resultSet ){
>         // Contributed by B. Schulte
>         // if the resultSet does not exist, execute it, to get a valid=20
> resultSet
>         // Foxpro calls this function to get all column-descriptions fo=
r=20
> its
>         // remote-views.
>         // This fixes the bug : ' I can't edit my remote-views in Visia=
l=20
> FoxPro'
>         this->executeStatement();
>     }


I'm ready to commit these changes, but I have a couple of questions.

1/ Is this->executeStatement() now redundant? Can I delete it, or is it=20
still required?


> Add this line 929 ( OdbcStatement::sqlExecute ):
>    =20
>         if ( resultSet )
>             releaseResultSet();
>=20

2/ My line numbering is out of synch with yours. I think this is where=20
you mean the code to go:

	try
		{
		retcode =3D executeStatement();
		}
	catch (SQLException& exception)
		{
		postError ("HY000", exception);
		retcode =3D SQL_ERROR;
		}

->=20
if ( resultSet )
->=20
	releaseResultSet();

	if (retcode && retcode !=3D SQL_SUCCESS_WITH_INFO)
		return retcode;


Paul
--=20

Paul Reeves
http://www.ibphoenix.com
Supporting users of Firebird and InterBase