[Firebird-odbc-devel] OdbcJdbc won't compile under GCC v7.3.0

[Chris R. <cr...@ae...>]

I’m using a clean build of Linux Mint 19.1 which has GCC v7.3.0. When I try to compile OdbcJdbc (both the latest from github and https://sourceforge.net/projects/firebird/files/firebird-ODBC-driver/2.0.5-Release/OdbcJdbc-src-2.0.5.156.tar.gz/download from the firebird website), it fails with an error:

make: [createdirs] Error 1 (ignored)
g++ -w -D_REENTRANT -D_PTHREADS -DEXTERNAL -DunixODBC -I/usr/include
g++ -I/usr/include -I/usr/lib/include -I/usr/include -fPIC -m64 -DNDEBUG
g++ -c ../../IscDbc/IscDatabaseMetaData.cpp -o
g++ Release_x86_64/obj/IscDatabaseMetaData.o
In file included from ../../IscDbc/IscDatabaseMetaData.cpp:47:0:
../../IscDbc/IscDatabaseMetaData.cpp: In member function 'virtual const char* IscDbcLibrary::IscDatabaseMetaData::getDriverVersion()':
../../IscDbc/../SetupAttributes.h:139:65: error: unable to find string literal operator 'operator""buildnum' with 'const char [7]', 'long unsigned int' arguments  #define BUILD_DRIVER_VERSION(major,minor,buildnum) major"."minor"."buildnum
                                                                 ^
../../IscDbc/../SetupAttributes.h:150:25: note: in expansion of macro 'BUILD_DRIVER_VERSION'
 #define DRIVER_VERSION  BUILD_DRIVER_VERSION( ZERO_MAJOR BUILD_STR2( MAJOR_VERSION ), ZERO_MINOR BUILD_STR2( MINOR_VERSION ), ZERO_BUILDNUM BUILD_STR2( BUILDNUM_VERSION ) )
                         ^~~~~~~~~~~~~~~~~~~~
../../IscDbc/IscDatabaseMetaData.cpp:350:9: note: in expansion of macro 'DRIVER_VERSION'
  return DRIVER_VERSION;
         ^~~~~~~~~~~~~~
makefile.linux:127: recipe for target 'Release_x86_64/obj/IscDatabaseMetaData.o' failed

Not sure what's changed with Gcc, but adding spaces around the BUILD_DRIVER_VERSION appears to fix the problem.

Patch is included.

CRule
The contents of this email message and any attachments are intended solely for the addressee(s) and may contain confidential and/or privileged information and may be legally protected from disclosure. If you are not the intended recipient of this message or their agent, or if this message has been addressed to you in error, please immediately alert the sender by reply email and then delete this message and any attachments. If you are not the intended recipient, you are hereby notified that any use, dissemination, copying, or storage of this message or its attachments is strictly prohibited.