[Firebird-docs] GitHub, Build bugs with Java 9, Assorted Questions!

[Norman D. <No...@du...>]

Evening All,

I'm in the process of making some corrections assigned to me on Jira and
I have downloaded and extracted the ALLJARS.ZIP file, as well as the 
stuff for the libs directory.

I have a clean install in other words.

I've forked the documentation repository so that I can work on it.

Q1. I assume, perhaps wrongly, that when I'm done I can create a pull 
request for the fixes?

Q2. Also, as we still copying everything into the B_Release branch?


I've done a "./build.sh docs" and everything has built ok, except, the 
multi-page HTML docs which don't go into dist/html, they just get built 
into the root folder. This truly messes up a "git status" command as all 
the files are listed.

Q3. Anyone else seen this? With a clean build? Oracle Java 9?

I did clear everything out again, from the root folder, and did a 
"./build.sh html" and got exactly the same mess. I can manually move 
things into dist, but I can't see anything in the build.xml that might 
be causing this - but I'm not an Ant guru I'm afraid.

Q4. Any clues?




Ok, moving on the the main topic, the ANT build fails to work under Java 
9. We are using the 2005 version of ANT - version 1.6.5 and this bug 
that hit me tonight, was fixed in version 1.9.8 and 1.10.0 back in 2016.

The bug produces the following output:

BUILD FAILED

/data/SourceCode/firebird-documentation/src/build/build.xml:770: The 
following error occurred while executing this line:

/data/SourceCode/firebird-documentation/src/build/build.xml:477: 
java.lang.NoClassDefFoundError: jdk/internal/reflect/ConstructorAccessorImpl


The workaround, courtesy of 
https://bz.apache.org/bugzilla/show_bug.cgi?id=59556, is to edit the file:

firebird-documentation/src/build/build.xml

To change the following 4 lines:

grep -n "com.icl.saxon.StyleSheet" 
/data/SourceCode/firebird-documentation/src/build/build.xml

404:        <java classname="com.icl.saxon.StyleSheet" 
classpathref="saxon.path" failonerror="true" fork="true">

477:        <java classname="com.icl.saxon.StyleSheet" 
classpathref="saxon.path" failonerror="true" fork="true">

646:        <java classname="com.icl.saxon.StyleSheet" 
classpathref="saxon.path" failonerror="true" fork="true">

694:        <java classname="com.icl.saxon.StyleSheet" 
classpathref="saxon.path" failonerror="true" fork="true">


Each of those lines needs the " fork=true" adding just before the 
closing '>' and if the above wraps around, they should be all on one line.

Lines 404, 477, 646 and 694 need amending.


Mine look like the above. Once done and saved, the docs will build again.

Sorry to be such a PITA with the questions, but at least I've solved one 
of my problems! ;-)


Cheers,
Norm.

-- 
Norman Dunbar
Dunbar IT Consultants Ltd

Registered address:
27a Lidget Hill
Pudsey
West Yorkshire
United Kingdom
LS28 7LG

Company Number: 05132767