[Firebird-docs] tools.jar and JAVA_HOME in build scripts

[Paul V. <pa...@vi...>]

Hello all,

In manual/src/build we have these build scripts for the manual module:

  build.bat (for Windows)
  build.sh  (for Linux)

Both scripts demand that the envvar JAVA_HOME be set, and both add
tools.jar to the Java classpath.

I suppose tools.jar is a leftover from a previous build tool, because
it is nowhere to be found on my systems (Windows and Linux) and the
builds work fine.

About JAVA_HOME:

- In build.bat JAVA_HOME is used twice, both times in the same line:
  first to call Java ("%JAVA_HOME%\bin\java.exe"), and a little later
  to add %JAVA_HOME%\lib\tools.jar to the classpath.

- In build.sh it is only used once, to add $JAVA_HOME/lib/tools.jar to
  the classpath. The executable is simply called as "java".

We seem to assume that the Java 2 executable will be in the search path
on Linux systems, but not on Windows systems. Is there a good reason for
this? To me, it would seem more logical to either call java like "java"
on boths OS'es, or to specify the path on both OS'es.

I just did test builds under Windows and Linux with the JAVA_HOME and
tools.jar references completely removed from the scripts (even with
JAVA_HOME unset in the environment) and everything was built correctly.

Looks like we can at least dump tools.jar. JAVA_HOME has to stay if we
want to specify the path to the executable; if not, it can go too.


Greetings,
Paul Vinkenoog