[Firebird-checkins] SF.net SVN: firebird:[62965] firebird/trunk/src/jrd/vio.cpp

[<hv...@us...>]

Revision: 62965
          http://sourceforge.net/p/firebird/code/62965
Author:   hvlad
Date:     2016-02-12 13:13:11 +0000 (Fri, 12 Feb 2016)
Log Message:
-----------
Simplest fix for bug CORE-5110 : False PK\FK violation could be reported when attachment used isc_dpb_no_garbage_collect flag

Modified Paths:
--------------
    firebird/trunk/src/jrd/vio.cpp

Modified: firebird/trunk/src/jrd/vio.cpp
===================================================================
--- firebird/trunk/src/jrd/vio.cpp	2016-02-12 13:04:02 UTC (rev 62964)
+++ firebird/trunk/src/jrd/vio.cpp	2016-02-12 13:13:11 UTC (rev 62965)
@@ -2266,8 +2266,10 @@
 		case tra_committed:
 			return !(rpb->rpb_flags & rpb_deleted);
 		case tra_dead:
-			if (transaction->tra_attachment->att_flags & ATT_no_cleanup)
-				return !foreign_key;
+			// Run backout else false key violation could be reported, see CORE-5110
+			//
+			// if (transaction->tra_attachment->att_flags & ATT_no_cleanup)
+			//	return !foreign_key;
 
 			{
 				jrd_rel::GCShared gcGuard(tdbb, rpb->rpb_relation);
@@ -2356,8 +2358,8 @@
 			return true;
 
 		case tra_dead:
-			if (transaction->tra_attachment->att_flags & ATT_no_cleanup)
-				return !foreign_key;
+			// if (transaction->tra_attachment->att_flags & ATT_no_cleanup)
+			//	return !foreign_key;
 
 			{
 				jrd_rel::GCShared gcGuard(tdbb, rpb->rpb_relation);

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.