Re: [Firebird-net-provider] 4.9.0 beta 1 release

[Геннадий З. <zab...@gm...>]

Here is my comments about Migration:
1. readonly IFbMigrationSqlGeneratorBehavior _behavior;
Is used only in migration operations DropColumn/AlterColumn, not used
in AddColumn.
2. We have additional implementation of Check in (0,1) for boolean
fields like implemented in SsdlToSql.cs
3. CreateItemName function doesn't support names longer than 31 character.
4. Also, I don't see where IFbMigrationSqlGeneratorBehavior can be
injected from client's app code.
5. I think the generator creation code in
DefaultFbMigrationSqlGeneratorBehavior will be copied to a possible
new implementation, so it is better to split logic. See base class:
https://github.com/zabulus/NETProvider/blob/master/NETProvider/src/EntityFramework.Firebird/DefaultFbMigrationSqlGeneratorBehavior.cs
and it's default implementation.
 https://github.com/zabulus/NETProvider/blob/master/NETProvider/src/EntityFramework.Firebird/CustomFbMigrationSqlGeneratorBehavior.cs

For all these suggestions I can prepare PRs this week without problems.


On 15 November 2015 at 13:04, Jiří Činčura <ji...@ci...> wrote:
> Hi *
>
> before I'll start cracking on FB 3 support (we have some good PRs) I'd
> like to get some features out. The list of changes is in
> http://tracker.firebirdsql.org/browse/DNET/fixforversion/10722 (and also
> some internal network stuff changes - check the commits if you're
> interested). Test it.
>
> Probably the long awaited is EF Migrations [3] support. You can us the
> new `FbMigrationSqlGenerator` [1] class. It's registered by default, but
> if you want to play harder check these lines [2]. Try it, discuss it
> here. Known issue [5].
>
> The version is available on *NuGet only* [4].
>
> [1]:
> https://github.com/cincuranet/FirebirdSql.Data.FirebirdClient/blob/master/NETProvider/src/EntityFramework.Firebird/FbMigrationSqlGenerator.cs
> [2]:
> https://github.com/cincuranet/FirebirdSql.Data.FirebirdClient/blob/master/NETProvider/src/FirebirdSql.Data.FirebirdClient/FirebirdClient/FbProviderServices.cs#L69,L70
> [3]: https://msdn.microsoft.com/en-us/data/jj591621.aspx
> [4]:
> https://www.nuget.org/packages/FirebirdSql.Data.FirebirdClient/4.9.0-beta1
> [5]: http://entityframework.codeplex.com/workitem/2683
>
> --
> Mgr. Jiří Činčura
> Independent IT Specialist
>
> ------------------------------------------------------------------------------
> _______________________________________________
> Firebird-net-provider mailing list
> Fir...@li...
> https://lists.sourceforge.net/lists/listinfo/firebird-net-provider