Re: [Firebird-devel] Firebird Transaction ID limit solution - Email found in subject

[Leyne, S. <Se...@br...>]

Alex,

> > The "simple" solution is to change the datatype of Transaction related
> variables from SLONG* to ULONG. The reality of this solution is,
> unfortunately, far uglier given the testing required to confirm that all
> references have been changed.
> >
> >
> > Sean
> >
> >
> > * for the life of me I don't understand why signed types where used for
> variables which could only contain positive values -- this is a common
> problem which is throughout the codebase.
> 
> This change was done in trunk.

To be clear, you have a code-branch that uses ULONG for transaction ID?


> The reason for signed type here was (at least visible reason) very simple
>  - into some functions using same parameter might
> be passed transaction number (positive value) and something else (negative
> value). I.e. negative sign meant 'this is not transaction' and function behaved
> according to it.

And some people have complained about some of my suggestions as being "hacks"!!!


Sean