From: Engineering <eng...@as...> - 2009-04-23 18:46:01
|
I tried to attach the patch, however for some reason the "attach" did not work (was using Google Chrome at the time, I think). I have attached the patch here, however with some reservations: - this patch just makes SQL_C_BIT treatment as a TinyInt for output. This may work in Windows, because of BOOL == int, however I do not know if this is the general case. May be a better idea to have BOOL == char (and at least on little-endian systems will not really care). - the change would assume that only 1 or 0 can be inside the selection, however it will happily transfer 2,3,4 and so on (which is hardly a BIT). I did consider writing a "tinyIntAsBit" which would make 0 == 0 and non-zero == 1, however for our internal functions we did not need it so I ended up with this fairly dirty hack. Regards, Andrei -----Original Message----- From: Nikolay Samofatov [mailto:nik...@re...] Sent: Thursday, April 23, 2009 2:36 PM To: fir...@li... Subject: Re: [Firebird-odbc-devel] [Suspected Spam] Re: Firebird ODBC: x64data lengthcompatibility Andrei, Engineering wrote: > > I found the JIRA tracker after a while (did submit a SQL_BIT support > patch in the mean time there) .. however that was quite hard to find > and I found the ODBC devel list instead. Since I got the message from > Nikolay that the patch was applied to 2.0, I guess I can skip the > posting in the tracker, however I will add any new patches there. > Thank you for the info. > > What are firebird developers likely to check - the devel list or the > tracker? The tracker seems to have few issues, but some of them seem > really ancient. > Myself and other guys from our lab (e.g. Roman Simakov) I know read odbc devel mailing list regularly. However if everyone is busy, some messages may be left unprocessed. If an item is posted to the tracker only it will get some attention for sure, but it is checked less frequently. Re SQL_BIT, I may apply this patch to HEAD. But could you please attach patch file to an issue instead of placing it inline as comments - it does not apply cleanly at this moment. > Regards, > > Andrei > -- Nikolay Samofatov, MBA Red Soft Corporation +1 416 710 6854 +7 495 721 3537 ------------------------------------------------------------------------ ------ Crystal Reports - New Free Runtime and 30 Day Trial Check out the new simplified licensign option that enables unlimited royalty-free distribution of the report engine for externally facing server and web deployment. http://p.sf.net/sfu/businessobjects _______________________________________________ Firebird-odbc-devel mailing list Fir...@li... https://lists.sourceforge.net/lists/listinfo/firebird-odbc-devel |