[Firebird-test] WBT: Peer Review

[Pavel C. <pc...@us...>]

Hi all,

Peer review is most often cited asset of Open Source development model, 
especially in relation to quality. So it's only natural that Peer review 
has it's place in Firebird Project.

Pro's and Con's:
This technique doesn't always work due to reviewer's time constraints, 
but helps especially to avoid the low-level design flaws.

Implementation:
Changes in CVS are reviewed as they appear (see firebird-checkins mailing 
list and newsgroup) by other developers. All problems are immediately 
reported and discussed in firebird-devel.

Current status:
We have that system already in place, because many changes made to the 
Firebird source tree are subject of review by at least one developer. But 
at least some (I hope that only some) changes are not checked at all. 
Actually, we haven't any shared knowledge, that peer review is really 
utilized in our project. Of course, some bugs were catched that way, but 
we don't know from others to what degree they do the review of changed 
code (if at all). There is not any developer designated to this task.

Questions for you:
1) Do you think that we should use peer review ? 


2) If yes, is the current state satisfactory for you ? 


3) If not, what changes do you recommend ?


Your comments would be greatly appreciated.
Best regards
Pavel Cisar
http://www.ibphoenix.com
For all your upto date Firebird and
InterBase information