|
From: Norman D. <No...@du...> - 2018-02-13 20:44:34
|
Evening All, I'm in the process of making some corrections assigned to me on Jira and I have downloaded and extracted the ALLJARS.ZIP file, as well as the stuff for the libs directory. I have a clean install in other words. I've forked the documentation repository so that I can work on it. Q1. I assume, perhaps wrongly, that when I'm done I can create a pull request for the fixes? Q2. Also, as we still copying everything into the B_Release branch? I've done a "./build.sh docs" and everything has built ok, except, the multi-page HTML docs which don't go into dist/html, they just get built into the root folder. This truly messes up a "git status" command as all the files are listed. Q3. Anyone else seen this? With a clean build? Oracle Java 9? I did clear everything out again, from the root folder, and did a "./build.sh html" and got exactly the same mess. I can manually move things into dist, but I can't see anything in the build.xml that might be causing this - but I'm not an Ant guru I'm afraid. Q4. Any clues? Ok, moving on the the main topic, the ANT build fails to work under Java 9. We are using the 2005 version of ANT - version 1.6.5 and this bug that hit me tonight, was fixed in version 1.9.8 and 1.10.0 back in 2016. The bug produces the following output: BUILD FAILED /data/SourceCode/firebird-documentation/src/build/build.xml:770: The following error occurred while executing this line: /data/SourceCode/firebird-documentation/src/build/build.xml:477: java.lang.NoClassDefFoundError: jdk/internal/reflect/ConstructorAccessorImpl The workaround, courtesy of https://bz.apache.org/bugzilla/show_bug.cgi?id=59556, is to edit the file: firebird-documentation/src/build/build.xml To change the following 4 lines: grep -n "com.icl.saxon.StyleSheet" /data/SourceCode/firebird-documentation/src/build/build.xml 404: <java classname="com.icl.saxon.StyleSheet" classpathref="saxon.path" failonerror="true" fork="true"> 477: <java classname="com.icl.saxon.StyleSheet" classpathref="saxon.path" failonerror="true" fork="true"> 646: <java classname="com.icl.saxon.StyleSheet" classpathref="saxon.path" failonerror="true" fork="true"> 694: <java classname="com.icl.saxon.StyleSheet" classpathref="saxon.path" failonerror="true" fork="true"> Each of those lines needs the " fork=true" adding just before the closing '>' and if the above wraps around, they should be all on one line. Lines 404, 477, 646 and 694 need amending. Mine look like the above. Once done and saved, the docs will build again. Sorry to be such a PITA with the questions, but at least I've solved one of my problems! ;-) Cheers, Norm. -- Norman Dunbar Dunbar IT Consultants Ltd Registered address: 27a Lidget Hill Pudsey West Yorkshire United Kingdom LS28 7LG Company Number: 05132767 |
|
From: Norman D. <No...@du...> - 2018-02-13 21:01:05
|
On 13/02/18 20:31, Norman Dunbar wrote at great length .... Q5. I appear to be no longer allowed to login to www...@cm...: The RSA host key for cms.firebirdsql.org has changed, and the key for the corresponding IP address 78.47.64.209 is unknown. This could either mean that DNS SPOOFING is happening or the IP address for the host and its host key have changed at the same time. I've cleaned out the known_hosts entry, as advised, and reconnected to add the new one back in, but now I'm asked for a password. Do I need to send Sergey my public key again? Cheers, Norm. -- Norman Dunbar Dunbar IT Consultants Ltd Registered address: 27a Lidget Hill Pudsey West Yorkshire United Kingdom LS28 7LG Company Number: 05132767 |
|
From: Mark R. <ma...@la...> - 2018-02-15 23:47:29
|
On 13-2-2018 21:31, Norman Dunbar wrote: > I'm in the process of making some corrections assigned to me on Jira and > I have downloaded and extracted the ALLJARS.ZIP file, as well as the > stuff for the libs directory. > > I have a clean install in other words. > > I've forked the documentation repository so that I can work on it. > > Q1. I assume, perhaps wrongly, that when I'm done I can create a pull > request for the fixes? Yes, you can. If you're not familiar with git: do your changes on a branch and create a pull request from that branch. That way you can keep your master the same as the upstream master (see https://help.github.com/articles/syncing-a-fork/). > Q2. Also, as we still copying everything into the B_Release branch? As far as I understand, yes. > I've done a "./build.sh docs" and everything has built ok, except, the > multi-page HTML docs which don't go into dist/html, they just get built > into the root folder. This truly messes up a "git status" command as all > the files are listed. > > Q3. Anyone else seen this? With a clean build? Oracle Java 9? The build doesn't work with Java 9. In any case, it works OK for me with Java 8, on Windows. > I did clear everything out again, from the root folder, and did a > "./build.sh html" and got exactly the same mess. I can manually move > things into dist, but I can't see anything in the build.xml that might > be causing this - but I'm not an Ant guru I'm afraid. > > Q4. Any clues? > > > > > Ok, moving on the the main topic, the ANT build fails to work under Java > 9. We are using the 2005 version of ANT - version 1.6.5 and this bug > that hit me tonight, was fixed in version 1.9.8 and 1.10.0 back in 2016. > > The bug produces the following output: > > BUILD FAILED > > /data/SourceCode/firebird-documentation/src/build/build.xml:770: The > following error occurred while executing this line: > > /data/SourceCode/firebird-documentation/src/build/build.xml:477: > java.lang.NoClassDefFoundError: > jdk/internal/reflect/ConstructorAccessorImpl > > > The workaround, courtesy of > https://bz.apache.org/bugzilla/show_bug.cgi?id=59556, is to edit the file: > > firebird-documentation/src/build/build.xml > > To change the following 4 lines: > > grep -n "com.icl.saxon.StyleSheet" > /data/SourceCode/firebird-documentation/src/build/build.xml > > 404: <java classname="com.icl.saxon.StyleSheet" > classpathref="saxon.path" failonerror="true" fork="true"> > > 477: <java classname="com.icl.saxon.StyleSheet" > classpathref="saxon.path" failonerror="true" fork="true"> > > 646: <java classname="com.icl.saxon.StyleSheet" > classpathref="saxon.path" failonerror="true" fork="true"> > > 694: <java classname="com.icl.saxon.StyleSheet" > classpathref="saxon.path" failonerror="true" fork="true"> > > > Each of those lines needs the " fork=true" adding just before the > closing '>' and if the above wraps around, they should be all on one line. It doesn't all need to be on one line, it just needs to be syntactically correct XML (and of course, valid Ant elements/attributes/values). > Lines 404, 477, 646 and 694 need amending. > > > Mine look like the above. Once done and saved, the docs will build again. > > Sorry to be such a PITA with the questions, but at least I've solved one > of my problems! ;-) Looking at the build.xml, the change that enabled this forking is the cause of the problem. In the html target, immediately after the java task you modified is the following: <!-- destdir/out parameters are ignored due to chunking so we move all chunked html files to their destination: --> <move todir="${html.dir}"> <fileset dir="${build.dir}" includes="*.html"/> </move> I have observed that under Java 8, it writes the files in src/build, and then after building, it moves them to the dist/html folder. Given you say you see the files in the root (and I assume you mean the root of the firebird-documentation repo), it is possible that forking changed the current working directory (from ./src/build to ./), as the fork is likely applying the Ant basedir as its working directory. As the files are now in a different location, the above move fails. A possible workaround is to add dir="${html.dir}" to the java task in the html task (when fork="true", this will use that as the current working directory), I haven't tested it though. However, I'm not sure if forking may cause other issues, so maybe we should tread carefully here. In any case, maybe we should look at updating ant (and maybe some of the other dependencies). Mark -- Mark Rotteveel |
|
From: Mark R. <ma...@la...> - 2018-02-15 23:57:29
|
On 13-2-2018 22:00, Norman Dunbar wrote: > On 13/02/18 20:31, Norman Dunbar wrote at great length .... > > Q5. I appear to be no longer allowed to login to > www...@cm...: > > The RSA host key for cms.firebirdsql.org has changed, > and the key for the corresponding IP address 78.47.64.209 > is unknown. This could either mean that > DNS SPOOFING is happening or the IP address for the host > and its host key have changed at the same time. > > > I've cleaned out the known_hosts entry, as advised, and reconnected to > add the new one back in, but now I'm asked for a password. > > Do I need to send Sergey my public key again? Possibly, it could also mean you're not offering the (right) SSH key. Mark -- Mark Rotteveel |
|
From: Norman D. <No...@du...> - 2018-02-16 17:54:58
|
On 14/02/18 08:11, Mark Rotteveel wrote: >> ... >> I've cleaned out the known_hosts entry, as advised, and reconnected to >> add the new one back in, but now I'm asked for a password. >> >> Do I need to send Sergey my public key again? > > Possibly, it could also mean you're not offering the (right) SSH key. > Hmm. Unfortunately, it's the only key I've needed to use. I have been able in the past to upload documents but I suspect that when the servers "changed" or whatever happened to cause my ssh connection to warn me about the server having changed, might be the cause. Perhaps. I shall resent Sergey my public key, just in case. If I can find his email address of course! Cheers, Norm. -- Norman Dunbar Dunbar IT Consultants Ltd Registered address: 27a Lidget Hill Pudsey West Yorkshire United Kingdom LS28 7LG Company Number: 05132767 |
|
From: Paul V. <pa...@vi...> - 2018-02-16 01:22:17
|
Hi Norman, > Q2. Also, as we still copying everything into the B_Release branch? Once a document is publishable, yes, that's the idea. Cheers, Paul |
|
From: Paul V. <pa...@vi...> - 2018-02-16 01:26:29
|
Norman wrote: > I've done a "./build.sh docs" and everything has built ok, except, the > multi-page HTML docs which don't go into dist/html, they just get built > into the root folder. This truly messes up a "git status" command as all > the files are listed. > > Q3. Anyone else seen this? With a clean build? Oracle Java 9? > > I did clear everything out again, from the root folder, and did a > "./build.sh html" and got exactly the same mess. I can manually move > things into dist, but I can't see anything in the build.xml that might > be causing this - but I'm not an Ant guru I'm afraid. > > Q4. Any clues? Sorry, no. I'm not an Ant guru either and it's a rather complicated tool, configuration-wise. I'd like to look into this but it won't be before Friday. Cheers, Paul |
|
From: Norman D. <No...@du...> - 2018-02-16 18:13:14
|
On 14/02/18 08:01, Mark Rotteveel wrote:
>> Q3. Anyone else seen this? With a clean build? Oracle Java 9?
>
> The build doesn't work with Java 9. In any case, it works OK for me with
> Java 8, on Windows.
Ok, good news there. I've downgraded Java to Java 8, removed the
fork="true" additions and built the docs again. No problems. So I'll
stick with Java 8 for now.
I might even try to learn some Ant stuff! Maybe. Perhaps.
> A possible workaround is to add dir="${html.dir}" to the java task in
> the html task (when fork="true", this will use that as the current
> working directory), I haven't tested it though. However, I'm not sure if
> forking may cause other issues, so maybe we should tread carefully here.
No worries. I didn't try this option as the Java 8 one worked fine. I've
reverted the build.xml back to how it was and it's fine. As you mention,
what other issues could have been unleashed!
> In any case, maybe we should look at updating ant (and maybe some of the
> other dependencies).
We need an Ant guru then! :-)
Thanks for your help.
Cheers,
Norm.
--
Norman Dunbar
Dunbar IT Consultants Ltd
Registered address:
27a Lidget Hill
Pudsey
West Yorkshire
United Kingdom
LS28 7LG
Company Number: 05132767
|
|
From: Mark R. <ma...@la...> - 2018-02-18 19:31:54
|
On 2018-02-16 19:13, Norman Dunbar wrote:
> On 14/02/18 08:01, Mark Rotteveel wrote:
>
>>> Q3. Anyone else seen this? With a clean build? Oracle Java 9?
>>
>> The build doesn't work with Java 9. In any case, it works OK for me
>> with Java 8, on Windows.
>
> Ok, good news there. I've downgraded Java to Java 8, removed the
> fork="true" additions and built the docs again. No problems. So I'll
> stick with Java 8 for now.
>
> I might even try to learn some Ant stuff! Maybe. Perhaps.
>
>
>> A possible workaround is to add dir="${html.dir}" to the java task in
>> the html task (when fork="true", this will use that as the current
>> working directory), I haven't tested it though. However, I'm not sure
>> if forking may cause other issues, so maybe we should tread carefully
>> here.
>
> No worries. I didn't try this option as the Java 8 one worked fine.
> I've reverted the build.xml back to how it was and it's fine. As you
> mention, what other issues could have been unleashed!
>
>
>> In any case, maybe we should look at updating ant (and maybe some of
>> the other dependencies).
>
> We need an Ant guru then! :-)
I have a bit of experience with ant. I was considering to do some
experiments to either upgrade ant, or maybe try and replace the ant
build file with a gradle build file, and at the same time remove the
need for the separate libs.zip and tools.zip download (both Ant and
Gradle can download dependencies on demand from a remote repository).
That might also make it easier to upgrade things in the future.
But it is a matter of time and energy, and I'm a bit low on both at the
moment.
Mark
|
|
From: Norman D. <No...@du...> - 2018-02-17 08:58:52
|
Testing testing. Apologies for the noise. A few emails I sent to the list yesterday have yet to arrive - they are not in spam either. Helen's reply to a query in FB-Support yesterday arrived here after the OP had responded to Helen. It can't be a moderation thing - as Helen wouldn't normally have to moderate herself! Sometimes, technology winds me up! Cheers, Norm. -- Norman Dunbar Dunbar IT Consultants Ltd Registered address: 27a Lidget Hill Pudsey West Yorkshire United Kingdom LS28 7LG Company Number: 05132767 |