firebird-devel

RE: [Firebird-devel] Prototypes differs!

[Samofatov, N. <Nic...@Br...>]

Hi, Konstantin!

> We saw 2 gds__database_cleanup with C and C++ linkage!!
>=20
> from alt_proto.h we can see
>=20
> ISC_STATUS    API_ROUTINE gds__database_cleanup(ISC_STATUS*,=20
>                        FB_API_HANDLE*,
>                          DatabaseCleanupRoutine*,=20
>    SLONG);
> from alt.cpp
> ISC_STATUS API_ROUTINE gds__database_cleanup(ISC_STATUS *=20
> status_vector,
>                      FB_API_HANDLE* db_handle,
>                      DatabaseCleanupRoutine *routine,
>                      void* arg)
> So definition and prototype differs in last argument void* vs SLONG.
> Wich is right?!

void*

>=20
> And so I think the same for other unresolved symbols. See my=20
> commits to dsql/user__proto.h
>=20
> So I advice to make all api functions extern "C" to throw=20
> compile error instead of digging such bugs !
>=20
> Any comments or opinions?

This function is not a part of public API and it is not used anywhere.
So I think it may be safely killed.

> Konstantin Kuznetsov

Nickolay

Re: [Firebird-devel] Prototypes differs!

[Konstantin K. <klk...@ns...>]

Hi Samofatov, Nickolay and All!

>>ISC_STATUS API_ROUTINE gds__database_cleanup(ISC_STATUS *
>>status_vector,
>>                     FB_API_HANDLE* db_handle,
>>                     DatabaseCleanupRoutine *routine,
>>                     void* arg)
>>So definition and prototype differs in last argument void* vs SLONG.
>>Wich is right?!
> 
> 
> void*
??, it will be void *

>>So I advice to make all api functions extern "C" to throw
>>compile error instead of digging such bugs !
>>
>>Any comments or opinions?
> 
> 
> This function is not a part of public API and it is not used anywhere.
> So I think it may be safely killed.
No, I got unresolved symbols linking fb_inet_server with libfbembed.so.

I wont to put
extern 'C' {
all of this functions{}

}
into *.cpp files to got compiller error instead of unresolved symbols.

Any opinions?




Konstantin

Re: [Firebird-devel] Prototypes differs!

[Blas R. S. <bl...@pu...>]

Hello Konstantin

At 04/06/2004 08:35, you wrote:
>Hi Samofatov, Nickolay and All!
>
>>>ISC_STATUS API_ROUTINE gds__database_cleanup(ISC_STATUS *
>>>status_vector,
>>>                     FB_API_HANDLE* db_handle,
>>>                     DatabaseCleanupRoutine *routine,
>>>                     void* arg)
>>>So definition and prototype differs in last argument void* vs SLONG.
>>>Wich is right?!
>>
>>void*
>??, it will be void *
>
>>>So I advice to make all api functions extern "C" to throw
>>>compile error instead of digging such bugs !
>>>
>>>Any comments or opinions?
>>
>>This function is not a part of public API and it is not used anywhere.
>>So I think it may be safely killed.
>No, I got unresolved symbols linking fb_inet_server with libfbembed.so.
>
>I wont to put
>extern 'C' {
>all of this functions{}
>
>}
>into *.cpp files to got compiller error instead of unresolved symbols.
>
>Any opinions?
>

Actually excluding some exceptions there are not extern "C" in cpp files 
and this intentional the extern "C" are defined only in the headers.

It cost some time to do this cleaning, please don't add this garbage again.


>Konstantin

Regards
Blas Rodriguez Somoza