firebird-devel

[Firebird-devel] Confusing message when security3 is not found

[Claudio V. C. <cv...@us...>]

Hello, I know security3.fdb is not in place because I'm using the Debug dir:

F:\fb3dev\fbbuild\firebird30\temp\Win32\Debug\firebird>isql -user sysdba
-pass masterkey
Use CONNECT or CREATE DATABASE to specify a database
SQL> create database 'user.fdb';
SQL> create user secondary pass 'sec';
Statement failed, SQLSTATE = 42000
Dynamic SQL Error
-SQL error code = -104
-Token unknown - line 1, column 23
-pass

I thought we would allow PASS as a shortcut for PASSWORD. Anyway:

SQL> create user secondary password 'sec';
Statement failed, SQLSTATE = 08001
unsuccessful metadata update
-CREATE USER SECONDARY failed
-I/O error during "CreateFile (open)" operation for file
"F:\fb3dev\fbbuild\firebird30\temp\Win32\Debug\firebird\/security3.fdb"
-Error while trying to open file
-The system cannot find the file specified.
SQL>

The final part of the path is confusing for the user:
firebird\/security3.fdb

I don't know if firebird is really looking for
temp/Win32/Debug/firebird//security3.fdb
or only the message contains an extra directory separator.

C.
---
Claudio Valderrama C.
Consultant, SW developer.

Re: [Firebird-devel] Confusing message when security3 is not found

[Alex <pes...@ma...>]

On 01/03/2014 01:47 PM, Claudio Valderrama C. wrote:
> Hello, I know security3.fdb is not in place because I'm using the Debug dir:
>
> F:\fb3dev\fbbuild\firebird30\temp\Win32\Debug\firebird>isql -user sysdba
> -pass masterkey
> Use CONNECT or CREATE DATABASE to specify a database
> SQL> create database 'user.fdb';
> SQL> create user secondary pass 'sec';
> Statement failed, SQLSTATE = 42000
> Dynamic SQL Error
> -SQL error code = -104
> -Token unknown - line 1, column 23
> -pass
>
> I thought we would allow PASS as a shortcut for PASSWORD.

Can you provide a sample where shortcuts are present in SQL? It's 
trivial to add PASS shortcut, but for me it looks like something out of 
SQL style.

> Anyway:
>
> SQL> create user secondary password 'sec';
> Statement failed, SQLSTATE = 08001
> unsuccessful metadata update
> -CREATE USER SECONDARY failed
> -I/O error during "CreateFile (open)" operation for file
> "F:\fb3dev\fbbuild\firebird30\temp\Win32\Debug\firebird\/security3.fdb"
> -Error while trying to open file
> -The system cannot find the file specified.
> SQL>
>
> The final part of the path is confusing for the user:
> firebird\/security3.fdb
>
> I don't know if firebird is really looking for
> temp/Win32/Debug/firebird//security3.fdb
> or only the message contains an extra directory separator.

Certainly it's a minor bug. I've tested at linux-only and 2 same 
separators (//) are merged correctly, but I've forgotten about windows 
with it's \.

A.

PS. On linux having >1 separator in the path does not prevent opening 
the file - Debug/firebird//security3.fdb is correct filename from kernel 
POV.

Re: [Firebird-devel] Confusing message when security3 is not found

[Ann H. <an...@qb...>]

On Sun, Jan 5, 2014 at 3:39 AM, Alex <pes...@ma...> wrote:

> O
> >
> > I thought we would allow PASS as a shortcut for PASSWORD.
>
> Can you provide a sample where shortcuts are present in SQL? It's
> trivial to add PASS shortcut, but for me it looks like something out of
> SQL style.
>

BIN (Binary), DEC (Decimal), CHAR (Character), VARCHAR (Varying
Character) NCHAR (National Character) and several others...   all
relatively old - the newer members of the standards committee must
have mastered touch typing.

Cheers,

Ann

Re: [Firebird-devel] Confusing message when security3 is not found

[Alex <pes...@ma...>]

On 01/06/2014 12:49 AM, Ann Harrison wrote:
> On Sun, Jan 5, 2014 at 3:39 AM, Alex <pes...@ma... 
> <mailto:pes...@ma...>> wrote:
>
>     O
>     >
>     > I thought we would allow PASS as a shortcut for PASSWORD.
>
>     Can you provide a sample where shortcuts are present in SQL? It's
>     trivial to add PASS shortcut, but for me it looks like something
>     out of
>     SQL style.
>
>
> BIN (Binary), DEC (Decimal), CHAR (Character), VARCHAR (Varying
> Character) NCHAR (National Character) and several others...   all
> relatively old - the newer members of the standards committee must
> have mastered touch typing.
>

Yes - and probably thats due to I've forgottem about full forms of this 
keywords.
Therefore I see the only one problem with adding shortcut: should it be 
PAS or PASS?
I suppose the original question was raised due to ogten use of -pass as 
a key in command line. But as for me I typically type -pas. Certainly we 
can easily support both forms. I just want others mind - is it worth 
adding some shortcut, and if yes - what?

Re: [Firebird-devel] Confusing message when security3 is not found

[Adriano d. S. F. <adr...@gm...>]

On 06/01/2014 10:46, Alex wrote:
>
> Yes - and probably thats due to I've forgottem about full forms of
> this keywords.
> Therefore I see the only one problem with adding shortcut: should it
> be PAS or PASS?
> I suppose the original question was raised due to ogten use of -pass
> as a key in command line. But as for me I typically type -pas.
> Certainly we can easily support both forms. I just want others mind -
> is it worth adding some shortcut, and if yes - what?
>
I don't think PAS/PASS should be added.

Thinking this way, we would need any sort of MIDDLENAME, MIDDLE_NAME,
MIDDLE NAME, etc, to satisfy every taste.


Adriano

Re: [Firebird-devel] Confusing message when security3 is not found

[Alex <pes...@ma...>]

On 01/06/2014 04:51 PM, Adriano dos Santos Fernandes wrote:
> On 06/01/2014 10:46, Alex wrote:
>> Yes - and probably thats due to I've forgottem about full forms of
>> this keywords.
>> Therefore I see the only one problem with adding shortcut: should it
>> be PAS or PASS?
>> I suppose the original question was raised due to ogten use of -pass
>> as a key in command line. But as for me I typically type -pas.
>> Certainly we can easily support both forms. I just want others mind -
>> is it worth adding some shortcut, and if yes - what?
>>
> I don't think PAS/PASS should be added.
>
> Thinking this way, we would need any sort of MIDDLENAME, MIDDLE_NAME,
> MIDDLE NAME, etc, to satisfy every taste.
>

Agreed with one small exception - if native english speakers suggest 
reasonable shortcut it's worth using it.

Re: [Firebird-devel] Confusing message when security3 is not found

[Alex P. <pes...@ma...>]

On 01/03/14 13:47, Claudio Valderrama C. wrote:
> Hello, I know security3.fdb is not in place because I'm using the Debug dir:
>
>

> The final part of the path is confusing for the user:
> firebird\/security3.fdb
>
> I don't know if firebird is really looking for
> temp/Win32/Debug/firebird//security3.fdb
> or only the message contains an extra directory separator.
>

Fixed.
Claudio, please check on windows when you have time.

Re: [Firebird-devel] Confusing message when security3 is not found

[Claudio V. C. <cv...@us...>]

> -----Original Message-----
> From: Alex Peshkoff [mailto:pes...@ma...] 
> Sent: Viernes, 31 de Enero de 2014 10:46
> 
> On 01/03/14 13:47, Claudio Valderrama C. wrote:
> 
> > The final part of the path is confusing for the user:
> > firebird\/security3.fdb
> >
> > I don't know if firebird is really looking for
> > temp/Win32/Debug/firebird//security3.fdb
> > or only the message contains an extra directory separator.
> >
> 
> Fixed.
> Claudio, please check on windows when you have time.

I had to comment an assertion in the engine to compile.

Now it's the correct path:
-I/O error during "CreateFile (open)" operation for file
"F:\FB3DEV\FBBUILD\FIREBIRD30\TEMP\WIN32\DEBUG\FIREBIRD\SECURITY3.FDB"
-Error while trying to open file
-The system cannot find the file specified.

I also did a crazy test in the same session:

SQL> create database 'security3.fdb';
Commit current transaction (y/n)?y
Committing.
SQL> create user secondary password 'sec';
Statement failed, SQLSTATE = HY000
unsuccessful metadata update
-CREATE USER SECONDARY failed
-bad parameters on attach or create database
-incompatible security database mode

I think the outcome is expected, but it doesn't depend if I'm running isql
alone (that runs the embedded engine) or I start firebird with -m -a before
isql.

C.

Re: [Firebird-devel] Confusing message when security3 is not found

[Alex P. <pes...@ma...>]

On 02/06/14 10:28, Claudio Valderrama C. wrote:
>> -----Original Message-----
>> From: Alex Peshkoff [mailto:pes...@ma...]
>> Sent: Viernes, 31 de Enero de 2014 10:46
>>
>> On 01/03/14 13:47, Claudio Valderrama C. wrote:
>>
>>> The final part of the path is confusing for the user:
>>> firebird\/security3.fdb
>>>
>>> I don't know if firebird is really looking for
>>> temp/Win32/Debug/firebird//security3.fdb
>>> or only the message contains an extra directory separator.
>>>
>> Fixed.
>> Claudio, please check on windows when you have time.
> I had to comment an assertion in the engine to compile.
>
> Now it's the correct path:
> -I/O error during "CreateFile (open)" operation for file
> "F:\FB3DEV\FBBUILD\FIREBIRD30\TEMP\WIN32\DEBUG\FIREBIRD\SECURITY3.FDB"
> -Error while trying to open file
> -The system cannot find the file specified.
>
> I also did a crazy test in the same session:
>
> SQL> create database 'security3.fdb';
> Commit current transaction (y/n)?y
> Committing.
> SQL> create user secondary password 'sec';
> Statement failed, SQLSTATE = HY000
> unsuccessful metadata update
> -CREATE USER SECONDARY failed
> -bad parameters on attach or create database
> -incompatible security database mode
>
> I think the outcome is expected, but it doesn't depend if I'm running isql
> alone (that runs the embedded engine) or I start firebird with -m -a before
> isql.
>

I know about this bug. Will be fixed soon.