#4930 numpy-py-1.13.0-1

[Jack Howarth]

Test packaging for a numpy-py-1.13.0-1 which only successfully builds with --no-build-as-nobody due to rewrite of numpy/distutils. Current info file changes are...

Index: numpy-py.info
===================================================================
RCS file: /cvsroot/fink/dists/10.9-libcxx/stable/main/finkinfo/sci/numpy-py.info,v
retrieving revision 1.12
diff -u -r1.12 numpy-py.info
--- numpy-py.info   19 Mar 2017 21:49:31 -0000  1.12
+++ numpy-py.info   12 Jun 2017 21:20:40 -0000
@@ -1,6 +1,6 @@
 Info2: <<
 Package: numpy-py%type_pkg[python]
-Version: 1.12.1
+Version: 1.13.0
 Revision: 1
 Maintainer: None <fink-devel@lists.sourceforge.net>
 Type: python (2.7 3.4 3.5 3.6)
@@ -12,16 +12,17 @@
    setuptools-tng-py%type_pkg[python]
 <<
 BuildConflicts: atlas
-Source: https://pypi.python.org/packages/a5/16/8a678404411842fe02d780b5f0a676ff4d79cd58f0f22acddab1b392e230/numpy-%v.zip#md5=33e5a84579f31829bbbba084fe0a4300
-Source-MD5: c75b072a984028ac746a6a332c209a91
+Source: https://pypi.python.org/packages/05/84/0feb999c05f252af50a5fbc463268044feda92cdaad8cb0d0a6073d76057/numpy-%v.zip#md5=fd044f0b8079abeaf5e6d2e93b2c1d03
+Source-MD5: fd044f0b8079abeaf5e6d2e93b2c1d03
 SourceRename: numpy-%v.zip
 PatchFile: numpy-py.patch
-PatchFile-MD5: 45a158bbad1e117673730d2101e3fdf4
+PatchFile-MD5: f146c2cf848a5b78b3b1b8b2dab30cde
 Conflicts: f2py-py%type_pkg[python], scipy-py%type_pkg[python] (<= 1:0.4)
 Replaces: f2py-py%type_pkg[python], scipy-py%type_pkg[python] (<= 1:0.4), scipy-core-py%type_pkg[python] (<< 1.3.0-6)
 Provides: f2py-py%type_pkg[python]
 PatchScript: sed 's|@FINKPREFIX@|%p|g' <%{PatchFile} | patch -p1
 CompileScript: <<
+#!/bin/bash -ev
  ATLAS=None LAPACK=/usr/lib BLAS=/usr/lib %p/bin/python%type_raw[python] setup.py build
 <<
 InstallScript: <<

The changes from 0.12,1 for numpy/distutls is posted at https://pastebin.com/RYWJ3gTm

[Jack Howarth]

Info file for numpy-py-1.13.0-1

[Jack Howarth]

Patch file for numpy-py-1.13.0-1

[Jack Howarth]

When built as fink nobody, the build fails with...

 compiler: gcc -fno-strict-aliasing -g -O2 -DNDEBUG -g -fwrapv -fwrapv -O3 -Wall -Wstrict-prototypes -I/sw/include

compile options: '-Inumpy/core/src/private -Inumpy/core/src -Inumpy/core -Inumpy/core/src/npymath -Inumpy/core/src/multiarray -Inumpy/core/src/umath -Inumpy/core/src/npysort -I/sw/include/python2.7 -c'
gcc: _configtest.c

failure.
removing: _configtest.c _configtest.o
Traceback (most recent call last):
  File "setup.py", line 392, in <module>
    setup_package()
  File "setup.py", line 384, in setup_package
    setup(**metadata)
  File "/sw/src/fink.build/numpy-py27-1.13.0-1/numpy-1.13.0/numpy/distutils/core.py", line 169, in setup
    return old_setup(**new_attr)
  File "/sw/lib/python2.7/distutils/core.py", line 151, in setup
    dist.run_commands()
  File "/sw/lib/python2.7/distutils/dist.py", line 953, in run_commands
    self.run_command(cmd)
  File "/sw/lib/python2.7/distutils/dist.py", line 972, in run_command
    cmd_obj.run()
  File "/sw/src/fink.build/numpy-py27-1.13.0-1/numpy-1.13.0/numpy/distutils/command/build.py", line 47, in run
    old_build.run(self)
  File "/sw/lib/python2.7/distutils/command/build.py", line 127, in run
    self.run_command(cmd_name)
  File "/sw/lib/python2.7/distutils/cmd.py", line 326, in run_command
    self.distribution.run_command(command)
  File "/sw/lib/python2.7/distutils/dist.py", line 972, in run_command
    cmd_obj.run()
  File "/sw/src/fink.build/numpy-py27-1.13.0-1/numpy-1.13.0/numpy/distutils/command/build_src.py", line 148, in run
    self.build_sources()
  File "/sw/src/fink.build/numpy-py27-1.13.0-1/numpy-1.13.0/numpy/distutils/command/build_src.py", line 159, in build_sources
    self.build_library_sources(*libname_info)
  File "/sw/src/fink.build/numpy-py27-1.13.0-1/numpy-1.13.0/numpy/distutils/command/build_src.py", line 294, in build_library_sources
    sources = self.generate_sources(sources, (lib_name, build_info))
  File "/sw/src/fink.build/numpy-py27-1.13.0-1/numpy-1.13.0/numpy/distutils/command/build_src.py", line 377, in generate_sources
    source = func(extension, build_dir)
  File "numpy/core/setup.py", line 674, in get_mathlib_info
    raise RuntimeError("Broken toolchain: cannot link a simple C program")
RuntimeError: Broken toolchain: cannot link a simple C program

[Derek Homeier]

The culprit seems to be _exec_command in numpy/distutils/exec_command.py:

+
+    if os.name == 'posix' and use_shell:
+        # On POSIX, subprocess always uses /bin/sh, override
         sh = os.environ.get('SHELL', '/bin/sh')
         if is_sequence(command):

Since $SHELL is /usr/bin/false for fink-bld, this is doomed to fail...

Quick (and dirty?) fix is to set it explicitly for setup.py - I am attaching the info file, updated for 1.13.1 (tested for py35 on 10.12 so far).
If this is against packaging policy or good practices, the check for 'posix' systems above would probably need to be patched somehow. Note that the requirement for $SHELL to be set includes the numpy.distutils tests (producing errors in test_compile1, test_compile2 and test_basic otherwise, so maybe this should be pointed out upstream.

[Derek Homeier]

Tested all versions on 10.11 and 10.12 now.

[Hanspeter Niederstrasser]

[#5028]