Menu
▾
▴
1 Attachments
#4403 libsamplerate0 0.1.8-2
closed
nobody
5
2014-04-23
2014-04-23
No
Hello, This is a slight patch to enable libsamplerate0 to compile on MacOS 10.9 with Xcode 5.1.1. It changes one of the examples file to #include <Carbon Carbon.h=""> instead of <Carbon.h>. Otherwise it's the same as the previous 0.1.8-1 package.
% fink -m rebuild libsamplerate0
works fine.
% dpkg -L libsamplerate0
/.
/sw
/sw/bin
/sw/bin/sndfile-resample
/sw/lib
/sw/share
/sw/share/doc
/sw/share/doc/libsamplerate0
/sw/share/doc/libsamplerate0/AUTHORS
/sw/share/doc/libsamplerate0/COPYING
/sw/share/doc/libsamplerate0/ChangeLog
/sw/share/doc/libsamplerate0/INSTALL
/sw/share/doc/libsamplerate0/NEWS
/sw/share/doc/libsamplerate0/README
/sw/share/doc/libsamplerate0/api.html
/sw/share/doc/libsamplerate0/api_callback.html
/sw/share/doc/libsamplerate0/api_full.html
/sw/share/doc/libsamplerate0/api_misc.html
/sw/share/doc/libsamplerate0/api_simple.html
/sw/share/doc/libsamplerate0/download.html
/sw/share/doc/libsamplerate0/faq.html
/sw/share/doc/libsamplerate0/history.html
/sw/share/doc/libsamplerate0/index.html
/sw/share/doc/libsamplerate0/license.html
/sw/share/doc/libsamplerate0/lists.html
/sw/share/doc/libsamplerate0/quality.html
/sw/share/doc/libsamplerate0/win32.html
/sw/share/doc/libsamplerate0-dev
/sw/share/doc/libsamplerate0-dev/html
/sw/share/doc/libsamplerate0-dev/html/SRC.css
/sw/share/doc/libsamplerate0-dev/html/SRC.png
/sw/share/doc/libsamplerate0-dev/html/api.html
/sw/share/doc/libsamplerate0-dev/html/api_callback.html
/sw/share/doc/libsamplerate0-dev/html/api_full.html
/sw/share/doc/libsamplerate0-dev/html/api_misc.html
/sw/share/doc/libsamplerate0-dev/html/api_simple.html
/sw/share/doc/libsamplerate0-dev/html/download.html
/sw/share/doc/libsamplerate0-dev/html/faq.html
/sw/share/doc/libsamplerate0-dev/html/history.html
/sw/share/doc/libsamplerate0-dev/html/index.html
/sw/share/doc/libsamplerate0-dev/html/license.html
/sw/share/doc/libsamplerate0-dev/html/lists.html
/sw/share/doc/libsamplerate0-dev/html/quality.html
/sw/share/doc/libsamplerate0-dev/html/win32.html
hmm, the description was garbled, by HTML interpretation of angle brackets. The code is currently erroneously #include <Carbon.h> and is patched to be #include <Carbon/Carbon.h>.
The patch seems reasonable to me. Out of curiosity, what was the failure that you were seeing? The current Fink packaging built for me with 10.9/Xcode 5.1.1.
Hmm, during compilation of examples/audio_out.c it crashed being unable to find Carbon.h, even with the original patch to change the include search path from /Developer/Headers/FlatCarbon to /System/Library/Frameworks/Carbon.framework/Headers. I’m running a fairly standard system (other than using a case-sensitive file system), but the only thing I can guess is the developer system default header search order is somehow different?
I’ve also submitted the patch to the upstream maintainer.
Leigh
Leigh M. Smith
mailto:leigh@leighsmith.com
http://www.leighsmith.com
One other note: your change appears not to have affected the .deb contents, so a revision bump isn't strictly necessary. And if you were seeing a fatal error, a revision bump definitely isn't necessary.
Well it was a fatal error for me, so that would imply we don’t need a revision bump, but if 0.1.8-1 built for you, that implies we do, right? :^) If simply an update to the existing package is required, will you accept the update and revert the revision number to 1?
Leigh
Leigh M. Smith
mailto:leigh@leighsmith.com
http://www.leighsmith.com
As I said, the .deb contents appeared identical--not just the files, but even the sizes of files. I'm fine with doing a rev-up just to be on the safe side, though.